From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Yadwinder Singh Brar <yadi.brar01@gmail.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
Liam Girdwood <lrg@ti.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chiwoong Byun <woong.byun@samsung.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: Re: [PATCH v3] mfd: max77686: Add device tree support.
Date: Fri, 6 Jul 2012 19:09:27 +0100 [thread overview]
Message-ID: <20120706180927.GG5437@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1341574375-17397-1-git-send-email-yadi.brar@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Fri, Jul 06, 2012 at 05:02:55PM +0530, Yadwinder Singh Brar wrote:
> + regulator_name {
> + regulator-compatible = LDOn/BUCKn
Trivial thing but this should really have "" as it's a string. But
people will probably figure that out.
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-06 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 3:58 [PATCH 1/6] mfd: max77686: Use pmic regmap to read pmic interrupt register Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 2/6] mfd: max77686: Apply irq_mask_cur before handling interrupts Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 3/6] mfd: max77686: Allow to specify interrupt through DT or platform file also Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 4/6] mfd: max77686: Add device tree support Yadwinder Singh Brar
2012-07-05 12:41 ` Mark Brown
2012-07-05 13:37 ` Yadwinder Singh Brar
2012-07-06 8:56 ` [PATCH v2] " Yadwinder Singh Brar
2012-07-06 11:32 ` [PATCH v3] " Yadwinder Singh Brar
2012-07-06 18:09 ` Mark Brown [this message]
2012-07-05 3:58 ` [PATCH 5/6] mfd: max77686: Remove the clocks from the list of regulators Yadwinder Singh Brar
2012-07-05 3:58 ` [PATCH 6/6] regulator: max77686: Add device tree support Yadwinder Singh Brar
2012-07-05 12:42 ` Mark Brown
2012-07-09 11:25 ` [PATCH 1/6] mfd: max77686: Use pmic regmap to read pmic interrupt register Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706180927.GG5437@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=woong.byun@samsung.com \
--cc=yadi.brar01@gmail.com \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.