From: Greg KH <greg@kroah.com>
To: Shachar Shemesh <shachar@liveu.tv>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Subject: [PATCH] tty ldisc: Close/Reopen race prevention should check the proper flag
Date: Fri, 6 Jul 2012 14:24:30 -0700 [thread overview]
Message-ID: <20120706212430.GA454@kroah.com> (raw)
In-Reply-To: <4FEFF3DF.9000909@liveu.tv>
On Sun, Jul 01, 2012 at 09:53:19AM +0300, Shachar Shemesh wrote:
> From: Shachar Shemesh <shachar@liveu.tv>
>
> Commit acfa747b introduced the TTY_HUPPING flag to distinguish
> closed TTY from currently closing ones. The test in tty_set_ldisc
> still remained pointing at the old flag. This causes pppd to
> sometimes lapse into uninterruptible sleep when killed and
> restarted.
>
> Signed-off-by: Shachar Shemesh <shachar@liveu.tv>
> ---
> Tested with 3.2.20 kernel.
>
> diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
> index 24b95db..a662a24 100644
> --- a/drivers/tty/tty_ldisc.c
> +++ b/drivers/tty/tty_ldisc.c
> @@ -658,7 +658,7 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc)
> goto enable;
> }
>
> - if (test_bit(TTY_HUPPED, &tty->flags)) {
> + if (test_bit(TTY_HUPPING, &tty->flags)) {
All tabs are converted to spaces and make this patch impossible to apply
:(
Care to try again?
greg k-h
next prev parent reply other threads:[~2012-07-06 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 6:53 Subject: [PATCH] tty ldisc: Close/Reopen race prevention should check the proper flag Shachar Shemesh
2012-07-06 21:24 ` Greg KH [this message]
2012-07-08 8:58 ` Shachar Shemesh
2012-07-09 16:44 ` Greg KH
2012-07-10 4:54 ` Shachar Shemesh
2012-09-19 19:25 ` Jiri Slaby
2012-09-22 8:35 ` Sasha Levin
2012-09-22 8:42 ` Jiri Slaby
2012-12-19 14:05 ` Džiugas Baltrūnas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120706212430.GA454@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shachar@liveu.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.