From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Mon, 9 Jul 2012 09:43:37 +0200 Subject: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c In-Reply-To: References: <1341572162-29126-1-git-send-email-javier.martin@vista-silicon.com> <20120709072809.GP30009@pengutronix.de> Message-ID: <20120709074337.GT30009@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: > On 9 July 2012 09:28, Sascha Hauer wrote: > > On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > >> This driver wasn't converted to the new clock changes > >> (clk_prepare_enable/clk_disable_unprepare). Also naming > >> of emma-prp related clocks for the i.MX27 was not correct. > >> --- > >> Enable clocks only for i.MX27. > >> > > > > Indeed, > > > >> > >> - pcdev->clk_csi = clk_get(&pdev->dev, NULL); > >> - if (IS_ERR(pcdev->clk_csi)) { > >> - dev_err(&pdev->dev, "Could not get csi clock\n"); > >> - err = PTR_ERR(pcdev->clk_csi); > >> - goto exit_kfree; > >> + if (cpu_is_mx27()) { > >> + pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb"); > >> + if (IS_ERR(pcdev->clk_csi)) { > >> + dev_err(&pdev->dev, "Could not get csi clock\n"); > >> + err = PTR_ERR(pcdev->clk_csi); > >> + goto exit_kfree; > >> + } > > > > but why? Now the i.MX25 won't get a clock anymore. > > What are the clocks needed by i.MX25? csi only? > > By the way, is anybody using this driver with i.MX25? It seems Baruch (added to Cc) has used it on an i.MX25. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:59448 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729Ab2GIHnm (ORCPT ); Mon, 9 Jul 2012 03:43:42 -0400 Date: Mon, 9 Jul 2012 09:43:37 +0200 From: Sascha Hauer To: javier Martin Cc: linux-media@vger.kernel.org, fabio.estevam@freescale.com, linux-arm-kernel@lists.infradead.org, laurent.pinchart@ideasonboard.com, g.liakhovetski@gmx.de, mchehab@infradead.org, kernel@pengutronix.de, Baruch Siach Subject: Re: [PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c Message-ID: <20120709074337.GT30009@pengutronix.de> References: <1341572162-29126-1-git-send-email-javier.martin@vista-silicon.com> <20120709072809.GP30009@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote: > On 9 July 2012 09:28, Sascha Hauer wrote: > > On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote: > >> This driver wasn't converted to the new clock changes > >> (clk_prepare_enable/clk_disable_unprepare). Also naming > >> of emma-prp related clocks for the i.MX27 was not correct. > >> --- > >> Enable clocks only for i.MX27. > >> > > > > Indeed, > > > >> > >> - pcdev->clk_csi = clk_get(&pdev->dev, NULL); > >> - if (IS_ERR(pcdev->clk_csi)) { > >> - dev_err(&pdev->dev, "Could not get csi clock\n"); > >> - err = PTR_ERR(pcdev->clk_csi); > >> - goto exit_kfree; > >> + if (cpu_is_mx27()) { > >> + pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb"); > >> + if (IS_ERR(pcdev->clk_csi)) { > >> + dev_err(&pdev->dev, "Could not get csi clock\n"); > >> + err = PTR_ERR(pcdev->clk_csi); > >> + goto exit_kfree; > >> + } > > > > but why? Now the i.MX25 won't get a clock anymore. > > What are the clocks needed by i.MX25? csi only? > > By the way, is anybody using this driver with i.MX25? It seems Baruch (added to Cc) has used it on an i.MX25. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |