All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Tao Ma <tm@tao.ma>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Use proper csum calculation in ext4_rename.
Date: Mon, 9 Jul 2012 10:07:51 -0400	[thread overview]
Message-ID: <20120709140751.GA3649@thunk.org> (raw)
In-Reply-To: <20120703170153.GC2342@tux1.beaverton.ibm.com>

On Tue, Jul 03, 2012 at 10:01:53AM -0700, Darrick J. Wong wrote:
> On Fri, Jun 22, 2012 at 11:38:34PM +0800, Tao Ma wrote:
> > From: Tao Ma <boyu.mt@taobao.com>
> > 
> > In ext4_rename, when the old name is a dir, we need to
> > change ".." to its new parent and journal the change, so
> > with metadata_csum enabled, we have to re-calc the csum.
> > 
> > As the first block of the dir can be either a htree root
> > or a normal directory block and we have different csum
> > calculation for these 2 types, we have to choose the right
> > one in ext4_rename.
> > 
> > btw, it is found by xfstests 013.
> 
> Good catch!
> 
> Acked-by: Darrick J. Wong <djwong@us.ibm.com>

Thanks, applied.

						- Ted

      reply	other threads:[~2012-07-09 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 15:38 [PATCH] ext4: Use proper csum calculation in ext4_rename Tao Ma
2012-07-03 17:01 ` Darrick J. Wong
2012-07-09 14:07   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120709140751.GA3649@thunk.org \
    --to=tytso@mit.edu \
    --cc=djwong@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tm@tao.ma \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.