From: Theodore Ts'o <tytso@mit.edu>
To: Liu Haibo <haiboliu6@gmail.com>
Cc: linux-ext4@vger.kernel.org, Haibo Liu <HaiboLiu6@gmai.com>
Subject: Re: [v2] ext4: delete a no useful sentence
Date: Mon, 9 Jul 2012 10:25:28 -0400 [thread overview]
Message-ID: <20120709142528.GA18072@thunk.org> (raw)
In-Reply-To: <1340303466-7967-1-git-send-email-HaiboLiu6@gmail.com>
On Thu, Jun 21, 2012 at 08:31:06AM -0000, Liu Haibo wrote:
> From: Haibo Liu <HaiboLiu6@gmai.com>
>
> In this patch, the sentence "poff = block % blocks_per_page"
> in ext4_mb_get_buddy_page_lock has no effect.
> So we should delete it to save cpu.
>
> v1->v2: update the patch subject and the patch comment.
>
> Signed-off-by: Haibo Liu <HaiboLiu6@gmail.com>
Applied, thanks. BTW, I modified the patch description a little to
note that the compiler would optimize out the statement, but it's
better to remove unused C statements.
- Ted
prev parent reply other threads:[~2012-07-09 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 18:31 [PATCH][v2] ext4: delete a no useful sentence Haibo
2012-07-09 14:25 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120709142528.GA18072@thunk.org \
--to=tytso@mit.edu \
--cc=HaiboLiu6@gmai.com \
--cc=haiboliu6@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.