From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode Date: Mon, 9 Jul 2012 10:11:07 -0700 Message-ID: <20120709171107.GC1341@google.com> References: <20120628180712.GC22641@google.com> <4FED10DB.7040500@huawei.com> <20120629165809.GB21048@google.com> <4FEE98EE.1050409@huawei.com> <20120630064724.GC14083@ZenIV.linux.org.uk> <20120630083421.GD14083@ZenIV.linux.org.uk> <20120703171033.GC555@google.com> <20120703173806.GD555@google.com> <4FF3D757.9060905@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ua+NDJLgCqmkg/NwM974ODH5tlMRjSYZjGEyGKh4AiU=; b=fGsF6yx/HqiCKtXgWSL1CO/tNKor/3DYUTobNpbVmicN6flaJtkUgyPHxElMdbcC/2 Hnh2vghqD2uMChI11NFi6Z6Yco8Yt2nDPx+qHSpvZPWg9OYY6SCFc9AbB7fH7wCKEUda aJbJXrHNMfrNIZ7SmgdgJMYm0cL9tqrI85qOsUvZg0l6VAimL5nStJWUwlLMvPxwLLvj vZkqFx6ILdgeflouT+jjWPRsUxt/7kUh0r6962SsQJcGK1wBlB3jVT3YTjLu5oHNFFCb OA1BMuRroVuymoTHx/wDkcnt+CpY7qeo/++oBpRycE6Rol8p/r/6tZ5ngqP9jUjWlbjl JmRg== Content-Disposition: inline In-Reply-To: <4FF3D757.9060905-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Li Zefan Cc: Al Viro , shyju pv , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sanil kumar , Masanari Iida On Wed, Jul 04, 2012 at 01:40:39PM +0800, Li Zefan wrote: > Tejun Heo wrote: > > >>From 6da2689412c78b97716ec524cc30baf7b46508cd Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Tue, 3 Jul 2012 10:32:26 -0700 > > > > While refactoring cgroup file removal path, 05ef1d7c4a "cgroup: > > introduce struct cfent" incorrectly changed the @dir argument of > > simple_unlink() to the inode of the file being deleted instead of that > > of the containing directory. > > > > The effect of this bug is minor - ctime and mtime of the parent > > weren't properly updated on file deletion. > > > > Fix it by using @cgrp->dentry->d_inode instead. > > > > Signed-off-by: Tejun Heo > > Reported-by: Al Viro > > > Acked-By: Li Zefan I think it's now a bit too late for for-3.5-fixes and the effect of the bug is rather minor. Applied to cgroup/for-3.6 w/ stable cc'd. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637Ab2GIRLO (ORCPT ); Mon, 9 Jul 2012 13:11:14 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:58274 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191Ab2GIRLM (ORCPT ); Mon, 9 Jul 2012 13:11:12 -0400 Date: Mon, 9 Jul 2012 10:11:07 -0700 From: Tejun Heo To: Li Zefan Cc: Al Viro , shyju pv , "linux-kernel@vger.kernel.org" , "cgroups@vger.kernel.org" , Sanil kumar , Masanari Iida Subject: Re: [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode Message-ID: <20120709171107.GC1341@google.com> References: <20120628180712.GC22641@google.com> <4FED10DB.7040500@huawei.com> <20120629165809.GB21048@google.com> <4FEE98EE.1050409@huawei.com> <20120630064724.GC14083@ZenIV.linux.org.uk> <20120630083421.GD14083@ZenIV.linux.org.uk> <20120703171033.GC555@google.com> <20120703173806.GD555@google.com> <4FF3D757.9060905@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FF3D757.9060905@huawei.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 04, 2012 at 01:40:39PM +0800, Li Zefan wrote: > Tejun Heo wrote: > > >>From 6da2689412c78b97716ec524cc30baf7b46508cd Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Tue, 3 Jul 2012 10:32:26 -0700 > > > > While refactoring cgroup file removal path, 05ef1d7c4a "cgroup: > > introduce struct cfent" incorrectly changed the @dir argument of > > simple_unlink() to the inode of the file being deleted instead of that > > of the containing directory. > > > > The effect of this bug is minor - ctime and mtime of the parent > > weren't properly updated on file deletion. > > > > Fix it by using @cgrp->dentry->d_inode instead. > > > > Signed-off-by: Tejun Heo > > Reported-by: Al Viro > > > Acked-By: Li Zefan I think it's now a bit too late for for-3.5-fixes and the effect of the bug is rather minor. Applied to cgroup/for-3.6 w/ stable cc'd. Thanks. -- tejun