From: Francois Romieu <romieu@fr.zoreil.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/6] r8169: support RTL8168G
Date: Tue, 10 Jul 2012 11:00:45 +0200 [thread overview]
Message-ID: <20120710090045.GA32387@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1341904369-5277-1-git-send-email-hayeswang@realtek.com>
(you should include a Signed-off-by)
Hayes Wang <hayeswang@realtek.com> :
> 1. Remove rtl_ocpdr_cond. No waiting is needed for mac_ocp_{write / read}.
Nit: it would not hurt to do a better job than me and save some commit noise
getting these things right before they pollute the history. :o)
> 2. Set ocp_base to OCP_STD_PHY_BASE after rtl8168g_1_hw_phy_config.
Can't it be stuffed into the firmware ?
The code does not explicitely switch from the PHY access context to
the extra OCP registers one and anything else in rtl8168g_1_hw_phy_config
seems to directly use the addresses it needs. So I'd expect the current
imbalance to come from the firmware, where it would make as much sense to
fix it
-> no imbalance after the firmware is applied
-> no useless instruction if the firmware is not used
--
Ueimor
next prev parent reply other threads:[~2012-07-10 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 22:44 [PATCH net-next 0/6] Pull request for 'davem-next.r8169' branch Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 1/6] r8169: add RTL8106E support Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 2/6] r8169: mdio_ops signature change Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 3/6] r8169: csi_ops " Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 4/6] r8169: ephy, eri and efuse functions signature changes Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 5/6] r8169: abstract out loop conditions Francois Romieu
2012-07-09 22:44 ` [PATCH net-next 6/6] r8169: support RTL8168G Francois Romieu
2012-07-10 5:36 ` Hayes Wang
2012-07-10 6:50 ` Francois Romieu
2012-07-11 8:29 ` David Miller
2012-07-10 7:12 ` Hayes Wang
2012-07-10 9:00 ` Francois Romieu [this message]
2012-07-09 22:57 ` [PATCH net-next 0/6] Pull request for 'davem-next.r8169' branch David Miller
2012-07-09 22:51 ` Francois Romieu
2012-07-09 23:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710090045.GA32387@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.