All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amy Fong <amy.fong@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package install failure on systems without /sbin/ldconfig
Date: Tue, 10 Jul 2012 09:45:22 -0400	[thread overview]
Message-ID: <20120710134522.GA20217@windriver.com> (raw)
In-Reply-To: <4FFBAE52.6070301@linux.intel.com>

On Mon, Jul 09, 2012 at 09:23:46PM -0700, Saul Wold wrote:
> On 07/09/2012 11:50 AM, Amy Fong wrote:
> >Package install failures due to issues in post install rules.
> >
> >package_do_shlibs only looks for libraries in a directory "lib", this should be
> >modified to the variable baselib.
> >
> >ldconfig_postinst_fragment failure observed on systems without /sbin/ldconfig
> >         [ -x /sbin/ldconfig ] && /sbin/ldconfig
> >results in the post install rule returning a failure. Modify to
> >         if [ -x /sbin/ldconfig ]; then /sbin/ldconfig; fi
> >
> If this is addressing bug #2723, then please mark it as follows:
> 
> [YOCTO #2723] in the commit message.
> 
> Also the commit subject should include the file name for example:
> package.bbclass: fix for package install failure on systems without
> /sbin/ldconfig
> 
> Thanks
> 	Sau!
> 

Thanks Saul, updated as follows....

[YOCTO #2723] package.bbclass: fix for package install failure on systems without /sbin/ldconfig
    
package_do_shlibs only looks for libraries in a directory "lib", this should be
modified to the variable baselib.
    
ldconfig_postinst_fragment failure observed on systems without /sbin/ldconfig
    [ -x /sbin/ldconfig ] && /sbin/ldconfig
results in the post install rule returning a failure. Modify to
    if [ -x /sbin/ldconfig ]; then /sbin/ldconfig; fi
    
Signed-off-by: Amy Fong <amy.fong@windriver.com>
---
 package.bbclass |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 56ab25c..28a263c 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1151,7 +1151,7 @@ emit_pkgdata[dirs] = "${PKGDESTWORK}/runtime"
 
 ldconfig_postinst_fragment() {
 if [ x"$D" = "x" ]; then
-	[ -x /sbin/ldconfig ] && /sbin/ldconfig
+	if [ -x /sbin/ldconfig ]; then /sbin/ldconfig ; fi
 fi
 }
 
@@ -1261,7 +1261,7 @@ python package_do_shlibs() {
 		return
 		
 	lib_re = re.compile("^.*\.so")
-	libdir_re = re.compile(".*/lib$")
+	libdir_re = re.compile(".*/%s$" % d.getVar('baselib', True))
 
 	packages = d.getVar('PACKAGES', True)
 	targetos = d.getVar('TARGET_OS', True)



  reply	other threads:[~2012-07-10 13:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 18:50 [PATCH] package install failure on systems without /sbin/ldconfig Amy Fong
2012-07-10  4:23 ` Saul Wold
2012-07-10 13:45   ` Amy Fong [this message]
2012-07-17 15:52 ` Saul Wold
  -- strict thread matches above, loose matches on Subject: below --
2012-07-09 15:38 Amy Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120710134522.GA20217@windriver.com \
    --to=amy.fong@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.