From: Fengguang Wu <wfg@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [yinghai:for-pci-pcie-link 104/104] drivers/pci/pcie-sysfs.c:27:25: sparse: symbol 'pcie_link_di
Date: Wed, 11 Jul 2012 08:29:44 +0000 [thread overview]
Message-ID: <20120711082944.GA24083@localhost> (raw)
In-Reply-To: <20120711082458.GA23164@localhost>
On Wed, Jul 11, 2012 at 04:24:58PM +0800, wfg@linux.intel.com wrote:
> Hi Yinghai,
>
> There are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-pcie-link
> head: d6396cb3ed85b8a95bd07d9c8f8f70b96a8f3d11
> commit: d6396cb3ed85b8a95bd07d9c8f8f70b96a8f3d11 [104/104] PCI: Add link_disable in /sysfs for pcie device
>
> All sparse warnings:
>
> + drivers/pci/pcie-sysfs.c:27:25: sparse: symbol 'pcie_link_disable_attr' was not declared. Should it be static?
> drivers/pci/pcie-sysfs.c:53:24: sparse: symbol 'pci_dev_pcie_attr_group' was not declared. Should it be static?
Sorry, that 2nd sparse warning is actually false warning.
The full diff won't compile.
Thanks,
Fengguang
prev parent reply other threads:[~2012-07-11 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 8:24 [yinghai:for-pci-pcie-link 104/104] drivers/pci/pcie-sysfs.c:27:25: sparse: symbol 'pcie_link_disabl wfg
2012-07-11 8:29 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711082944.GA24083@localhost \
--to=wfg@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.