To: powertop@lists.01.org
Subject: Re: [Powertop] Device list sort function bug
Date: Wed, 11 Jul 2012 09:55:10 +0200 [thread overview]
Message-ID: <201207110955.10925.dl9pf@gmx.de> (raw)
In-Reply-To: 20120711073342.GA3081@swordfish
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
Yes, in an hour or so.
Best,
JS
Am Mittwoch, 11. Juli 2012, 09:33:42 schrieb Sergey Senozhatsky:
> On (07/11/12 10:11), Igor Zhbanov wrote:
> > Sometimes PowerTOP dies with a Segmentation Fault while generating
> > the report. Little investigation shown that it dies while sorting
> > the device list. The problem is that comparison function devlist_sort
> > is incorrect.
> >
> > The function should return true if first argument "preceeds" second.
> > But when strcmp() is used, it can return -1, 0 and 1. So both -1 and 1
> > values are silently converted to true, which is wrong. It confuses the
> > sort() function and it crosses boundary of array.
>
> Jan, could you please test this one?
>
> Thanks in advance,
>
> -ss
next reply other threads:[~2012-07-11 7:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 7:55 [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-17 22:09 [Powertop] Device list sort function bug Chris Ferron
2012-07-11 14:43
2012-07-11 8:57 Paul Menzel
2012-07-11 8:16 Igor Zhbanov
2012-07-11 7:52 Paul Menzel
2012-07-11 7:33 Sergey Senozhatsky
2012-07-11 6:11 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207110955.10925.dl9pf@gmx.de \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.