From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Wilson Subject: Re: LIBDIR not set during xen build Date: Wed, 11 Jul 2012 10:44:05 -0700 Message-ID: <20120711174405.GB5064@US-SEA-R8XVZTX> References: <20120711082607.GA3079@aepfle.de> <20120711163614.GA5064@US-SEA-R8XVZTX> <20120711165113.GA20784@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120711165113.GA20784@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, Jul 11, 2012 at 09:51:13AM -0700, Olaf Hering wrote: > On Wed, Jul 11, Matt Wilson wrote: > > > On Wed, Jul 11, 2012 at 01:26:07AM -0700, Olaf Hering wrote: > > > > > > How is LIBDIR in xen/Makefile supposed to be set? During 'make xen' all > > > the fine efi stuff is installed in /efi instead of /usr/lib64/efi. > > > And: is /usr/lib64/efi the correct place anyway? > > > > Are you noticing new broken behavior? Ian C. recently committed a > > change I made to honor ./configure --libdir=... for tools targets [1], > > but that shouldn't have affected the xen subtree. > > Matt, > > I do indeed notice some build breakage since the last two weeks. But > since xen/Makefile did not change I wonder how it worked up to now. I > have not yet bisected the issue. > > On the other hand, building xen is not supposed to rely on configure. > Perhaps an easy change is to just define LIBDIR in xen/Makefile. I think that other efi binaries like elilo.efi usually live in /usr/lib64/efi, so perhaps in the short term there should just be an explicit EFIDIR variable in xen/Makefile. Ultimately I think that LIBDIR should follow the ./configure --libdir setting, which would land the efi binaries in the wrong place. Matt