From: Alexander Strasser <eclipse7@gmx.net>
To: git@vger.kernel.org
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH 4/6] t4012: Break up pipe into serial redirections
Date: Thu, 12 Jul 2012 00:12:56 +0200 [thread overview]
Message-ID: <20120711221256.GA21355@akuma> (raw)
Do not hide possible git errors by masquerading its process
exit status.
Signed-off-by: Alexander Strasser <eclipse7@gmx.net>
---
t/t4012-diff-binary.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
index 60c2f6c..daf8234 100755
--- a/t/t4012-diff-binary.sh
+++ b/t/t4012-diff-binary.sh
@@ -64,7 +64,8 @@ test_expect_success 'apply --numstat understands diff --binary format' '
# apply needs to be able to skip the binary material correctly
# in order to report the line number of a corrupt patch.
test_expect_success 'apply detecting corrupt patch correctly' '
- git diff | sed -e "s/-CIT/xCIT/" >broken &&
+ git diff >output &&
+ sed -e "s/-CIT/xCIT/" <output >broken &&
if git apply --stat --summary broken 2>detected
then
echo unhappy - should have detected an error
--
1.7.10.2.552.gaa3bb87
reply other threads:[~2012-07-11 22:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711221256.GA21355@akuma \
--to=eclipse7@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.