From: Andrew Morton <akpm@linux-foundation.org>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"chris@zankel.net" <chris@zankel.net>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"cmetcalf@tilera.com" <cmetcalf@tilera.com>
Subject: Re: [PATCH 2/3] ipc: allow compat IPC version field parsing if !ARCH_WANT_OLD_COMPAT_IPC
Date: Thu, 12 Jul 2012 01:59:49 -0700 [thread overview]
Message-ID: <20120712015949.88692ecf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120712084756.GB2816@mudshark.cambridge.arm.com>
On Thu, 12 Jul 2012 09:47:56 +0100 Will Deacon <will.deacon@arm.com> wrote:
> > > static inline int compat_ipc_parse_version(int *cmd)
> > > {
> > > -#ifdef CONFIG_ARCH_WANT_OLD_COMPAT_IPC
> > > +#ifdef __ARCH_WANT_COMPAT_IPC_PARSE_VERSION
> > > int version = *cmd & IPC_64;
> > >
> > > /* this is tricky: architectures that have support for the old
> >
> > Could we do this purely in Kconfig? Add a new
> > CONFIG_ARCH_WANT_COMPAT_IPC_PARSE_VERSION and always set it true if
> > CONFIG_ARCH_WANT_OLD_COMPAT_IPC?
>
> That would also work, although the current approach mirrors what is done for
> the native case (i.e. this is the compat equivalent of
> __ARCH_WANT_IPC_PARSE_VERSION).
>
> I'm not too fussed either way, so I can change it if you prefer?
It would be best to change both as a separate patch.
It's not a big deal: just a matter of consistency and use of up-to-date
idioms.
next prev parent reply other threads:[~2012-07-12 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 15:32 [PATCH 0/3] random compat IPC fixes required by AArch64 Will Deacon
2012-07-11 15:32 ` [PATCH 1/3] ipc: add COMPAT_SHMLBA support Will Deacon
2012-07-11 15:32 ` [PATCH 2/3] ipc: allow compat IPC version field parsing if !ARCH_WANT_OLD_COMPAT_IPC Will Deacon
2012-07-11 16:07 ` Chris Metcalf
2012-07-11 16:07 ` Chris Metcalf
2012-07-11 21:40 ` Andrew Morton
2012-07-12 8:47 ` Will Deacon
2012-07-12 8:59 ` Andrew Morton [this message]
2012-07-13 10:39 ` Will Deacon
2012-07-13 10:39 ` Will Deacon
2012-07-11 15:32 ` [PATCH 3/3] ipc: compat: use signed size_t types for msgsnd and msgrcv Will Deacon
2012-07-11 16:06 ` Chris Metcalf
2012-07-11 16:06 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712015949.88692ecf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Catalin.Marinas@arm.com \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.