All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xen.org
Subject: [PATCH] qemu-traditional: fix no-return-in-nonvoid-function
Date: Thu, 12 Jul 2012 10:13:26 +0200	[thread overview]
Message-ID: <20120712081326.GA6696@aepfle.de> (raw)

rpm post-build-checks found a few issues in qemu-xen-traditional and
marks them as errors.

I: Program returns random data in a function
E: xen no-return-in-nonvoid-function savevm.c:215
E: xen no-return-in-nonvoid-function /usr/src/packages/BUILD/xen-4.2.25602/non-dbg/stubdom/ioemu/xenfbfront.c:361

Signed-off-by: Olaf Hering <olaf@aepfle.de>

---
 qemu-xen.h   |    2 +-
 savevm.c     |    2 +-
 xenfbfront.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Index: qemu-xen-traditional-dir-remote/qemu-xen.h
===================================================================
--- qemu-xen-traditional-dir-remote.orig/qemu-xen.h
+++ qemu-xen-traditional-dir-remote/qemu-xen.h
@@ -129,7 +129,7 @@ int xenstore_find_device(BlockDriverStat
 
 /* xenfbfront.c */
 int xenfb_pv_display_init(DisplayState *ds);
-int xenfb_pv_display_vram(void *vram_start);
+void xenfb_pv_display_vram(void *vram_start);
 int xenfb_connect_vkbd(const char *path);
 int xenfb_connect_vfb(const char *path);
 
Index: qemu-xen-traditional-dir-remote/savevm.c
===================================================================
--- qemu-xen-traditional-dir-remote.orig/savevm.c
+++ qemu-xen-traditional-dir-remote/savevm.c
@@ -210,8 +210,8 @@ static int popen_close(void *opaque)
     QEMUFilePopen *s = opaque;
     pclose(s->popen_file);
     qemu_free(s);
-    return 0;
 #endif
+    return 0;
 }
 
 QEMUFile *qemu_popen(FILE *popen_file, const char *mode)
Index: qemu-xen-traditional-dir-remote/xenfbfront.c
===================================================================
--- qemu-xen-traditional-dir-remote.orig/xenfbfront.c
+++ qemu-xen-traditional-dir-remote/xenfbfront.c
@@ -355,7 +355,7 @@ int xenfb_pv_display_init(DisplayState *
     return 0;
 }
 
-int xenfb_pv_display_vram(void *data)
+void xenfb_pv_display_vram(void *data)
 {
     vga_vram = data;
 }

             reply	other threads:[~2012-07-12  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12  8:13 Olaf Hering [this message]
2012-07-23 16:57 ` [PATCH] qemu-traditional: fix no-return-in-nonvoid-function Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120712081326.GA6696@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.