From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: [PATCH] qemu-traditional: fix no-return-in-nonvoid-function Date: Thu, 12 Jul 2012 10:13:26 +0200 Message-ID: <20120712081326.GA6696@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org rpm post-build-checks found a few issues in qemu-xen-traditional and marks them as errors. I: Program returns random data in a function E: xen no-return-in-nonvoid-function savevm.c:215 E: xen no-return-in-nonvoid-function /usr/src/packages/BUILD/xen-4.2.25602/non-dbg/stubdom/ioemu/xenfbfront.c:361 Signed-off-by: Olaf Hering --- qemu-xen.h | 2 +- savevm.c | 2 +- xenfbfront.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Index: qemu-xen-traditional-dir-remote/qemu-xen.h =================================================================== --- qemu-xen-traditional-dir-remote.orig/qemu-xen.h +++ qemu-xen-traditional-dir-remote/qemu-xen.h @@ -129,7 +129,7 @@ int xenstore_find_device(BlockDriverStat /* xenfbfront.c */ int xenfb_pv_display_init(DisplayState *ds); -int xenfb_pv_display_vram(void *vram_start); +void xenfb_pv_display_vram(void *vram_start); int xenfb_connect_vkbd(const char *path); int xenfb_connect_vfb(const char *path); Index: qemu-xen-traditional-dir-remote/savevm.c =================================================================== --- qemu-xen-traditional-dir-remote.orig/savevm.c +++ qemu-xen-traditional-dir-remote/savevm.c @@ -210,8 +210,8 @@ static int popen_close(void *opaque) QEMUFilePopen *s = opaque; pclose(s->popen_file); qemu_free(s); - return 0; #endif + return 0; } QEMUFile *qemu_popen(FILE *popen_file, const char *mode) Index: qemu-xen-traditional-dir-remote/xenfbfront.c =================================================================== --- qemu-xen-traditional-dir-remote.orig/xenfbfront.c +++ qemu-xen-traditional-dir-remote/xenfbfront.c @@ -355,7 +355,7 @@ int xenfb_pv_display_init(DisplayState * return 0; } -int xenfb_pv_display_vram(void *data) +void xenfb_pv_display_vram(void *data) { vga_vram = data; }