All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
Date: Thu, 12 Jul 2012 08:36:26 -0700	[thread overview]
Message-ID: <20120712153626.GD17365@kroah.com> (raw)
In-Reply-To: <1342067547-6276-1-git-send-email-cw00.choi@samsung.com>

On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote:
> This patch modify 'Kconfig' of EXTCON Subsystem to support either
> active or inactive of EXTCON Subsystem. The various subsystem refer
> to EXTCON subsystem for controlling external connector, so core class
> of EXTCON should be included in kernel image. If EXTCON subsystem is
> builded with MODULE, other subsystem have build break because of
> linking the core class of EXTCON.

Then something else is wrong, as the extcon_class code should be able to
be built as a module.  Don't load up systems with kernel code that they
don't need (think of distro kernels that have to build everything.)

So no, please fix the real problem here, I will not take this patch,
sorry.

greg k-h

  reply	other threads:[~2012-07-12 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12  4:32 [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break Chanwoo Choi
2012-07-12 15:36 ` Greg KH [this message]
2012-07-12 23:45   ` Chanwoo Choi
2012-07-12 16:16 ` Mark Brown
2012-07-12 23:46   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120712153626.GD17365@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.