Re: [PATCH 1/4] netfilter: xt_recent: remove ip_list_hash_size parameter

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Jul 11, 2012 at 01:52:27AM +0200, Jan Engelhardt wrote:
> This module parameter has no effect, since the user-specified value is
> overriden by the init function anyway.

My only concern with this is to break existing configuration that sets
that module parameter.

I wonder if it's useful to fix this module parameter to make it work
instead.

> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
>  net/netfilter/xt_recent.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/xt_recent.c b/net/netfilter/xt_recent.c
> index c426497..b980b3f 100644
> --- a/net/netfilter/xt_recent.c
> +++ b/net/netfilter/xt_recent.c
> @@ -50,7 +50,6 @@ static unsigned int ip_list_uid = 0;
>  static unsigned int ip_list_gid = 0;
>  module_param(ip_list_tot, uint, 0400);
>  module_param(ip_pkt_list_tot, uint, 0400);
> -module_param(ip_list_hash_size, uint, 0400);
>  module_param(ip_list_perms, uint, 0400);
>  module_param(ip_list_uid, uint, S_IRUGO | S_IWUSR);
>  module_param(ip_list_gid, uint, S_IRUGO | S_IWUSR);
> -- 
> 1.7.7
>