From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Date: Thu, 12 Jul 2012 10:05:19 -0700 Message-ID: <20120712170519.GA20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, joshhunt00-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, vwadekar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bpm-sJ/iWh9BUns@public.gmane.org, elder-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org, gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org, johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org To: Fengguang Wu Return-path: Content-Disposition: inline In-Reply-To: <20120712130648.GA19214@localhost> Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org Hello, Fengguang. On Thu, Jul 12, 2012 at 09:06:48PM +0800, Fengguang Wu wrote: > [ 0.207977] WARNING: at /c/kernel-tests/mm/kernel/workqueue.c:1217 worker_enter_idle+0x2b8/0x32b() > [ 0.207977] Modules linked in: > [ 0.207977] Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc6-08414-g9645fff #15 > [ 0.207977] Call Trace: > [ 0.207977] [] ? worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] warn_slowpath_common+0xae/0xdb > [ 0.207977] [] warn_slowpath_null+0x28/0x31 > [ 0.207977] [] worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] start_worker+0x26/0x42 > [ 0.207977] [] init_workqueues+0x2d2/0x59a > [ 0.207977] [] ? usermodehelper_init+0x8a/0x8a > [ 0.207977] [] do_one_initcall+0xce/0x272 > [ 0.207977] [] kernel_init+0x12e/0x3c1 > [ 0.207977] [] kernel_thread_helper+0x4/0x10 > [ 0.207977] [] ? retint_restore_args+0x13/0x13 > [ 0.207977] [] ? start_kernel+0x737/0x737 > [ 0.207977] [] ? gs_change+0x13/0x13 Yeah, I forgot to flip the WARN_ON_ONCE() condition so that it checks nr_running before looking at pool->nr_running. The warning is spurious. Will post fix soon. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q6CH5QM6064159 for ; Thu, 12 Jul 2012 12:05:26 -0500 Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53]) by cuda.sgi.com with ESMTP id 2JWoFyLu4tzHcW4T (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Thu, 12 Jul 2012 10:05:25 -0700 (PDT) Received: by yhp26 with SMTP id 26so3318193yhp.26 for ; Thu, 12 Jul 2012 10:05:25 -0700 (PDT) Date: Thu, 12 Jul 2012 10:05:19 -0700 From: Tejun Heo Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Message-ID: <20120712170519.GA20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120712130648.GA19214@localhost> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Fengguang Wu Cc: axboe@kernel.dk, elder@kernel.org, rni@google.com, martin.petersen@oracle.com, linux-bluetooth@vger.kernel.org, torvalds@linux-foundation.org, marcel@holtmann.org, linux-kernel@vger.kernel.org, vwadekar@nvidia.com, swhiteho@redhat.com, herbert@gondor.hengli.com.au, bpm@sgi.com, linux-crypto@vger.kernel.org, gustavo@padovan.org, xfs@oss.sgi.com, joshhunt00@gmail.com, davem@davemloft.net, vgoyal@redhat.com, johan.hedberg@gmail.com Hello, Fengguang. On Thu, Jul 12, 2012 at 09:06:48PM +0800, Fengguang Wu wrote: > [ 0.207977] WARNING: at /c/kernel-tests/mm/kernel/workqueue.c:1217 worker_enter_idle+0x2b8/0x32b() > [ 0.207977] Modules linked in: > [ 0.207977] Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc6-08414-g9645fff #15 > [ 0.207977] Call Trace: > [ 0.207977] [] ? worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] warn_slowpath_common+0xae/0xdb > [ 0.207977] [] warn_slowpath_null+0x28/0x31 > [ 0.207977] [] worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] start_worker+0x26/0x42 > [ 0.207977] [] init_workqueues+0x2d2/0x59a > [ 0.207977] [] ? usermodehelper_init+0x8a/0x8a > [ 0.207977] [] do_one_initcall+0xce/0x272 > [ 0.207977] [] kernel_init+0x12e/0x3c1 > [ 0.207977] [] kernel_thread_helper+0x4/0x10 > [ 0.207977] [] ? retint_restore_args+0x13/0x13 > [ 0.207977] [] ? start_kernel+0x737/0x737 > [ 0.207977] [] ? gs_change+0x13/0x13 Yeah, I forgot to flip the WARN_ON_ONCE() condition so that it checks nr_running before looking at pool->nr_running. The warning is spurious. Will post fix soon. Thanks. -- tejun _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161326Ab2GLRFb (ORCPT ); Thu, 12 Jul 2012 13:05:31 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:63377 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934143Ab2GLRF0 (ORCPT ); Thu, 12 Jul 2012 13:05:26 -0400 Date: Thu, 12 Jul 2012 10:05:19 -0700 From: Tejun Heo To: Fengguang Wu Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, joshhunt00@gmail.com, axboe@kernel.dk, rni@google.com, vgoyal@redhat.com, vwadekar@nvidia.com, herbert@gondor.hengli.com.au, davem@davemloft.net, linux-crypto@vger.kernel.org, swhiteho@redhat.com, bpm@sgi.com, elder@kernel.org, xfs@oss.sgi.com, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, martin.petersen@oracle.com Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Message-ID: <20120712170519.GA20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120712130648.GA19214@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Fengguang. On Thu, Jul 12, 2012 at 09:06:48PM +0800, Fengguang Wu wrote: > [ 0.207977] WARNING: at /c/kernel-tests/mm/kernel/workqueue.c:1217 worker_enter_idle+0x2b8/0x32b() > [ 0.207977] Modules linked in: > [ 0.207977] Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc6-08414-g9645fff #15 > [ 0.207977] Call Trace: > [ 0.207977] [] ? worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] warn_slowpath_common+0xae/0xdb > [ 0.207977] [] warn_slowpath_null+0x28/0x31 > [ 0.207977] [] worker_enter_idle+0x2b8/0x32b > [ 0.207977] [] start_worker+0x26/0x42 > [ 0.207977] [] init_workqueues+0x2d2/0x59a > [ 0.207977] [] ? usermodehelper_init+0x8a/0x8a > [ 0.207977] [] do_one_initcall+0xce/0x272 > [ 0.207977] [] kernel_init+0x12e/0x3c1 > [ 0.207977] [] kernel_thread_helper+0x4/0x10 > [ 0.207977] [] ? retint_restore_args+0x13/0x13 > [ 0.207977] [] ? start_kernel+0x737/0x737 > [ 0.207977] [] ? gs_change+0x13/0x13 Yeah, I forgot to flip the WARN_ON_ONCE() condition so that it checks nr_running before looking at pool->nr_running. The warning is spurious. Will post fix soon. Thanks. -- tejun