From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
Date: Thu, 12 Jul 2012 17:27:25 +0000 [thread overview]
Message-ID: <20120712172725.GA9270@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120711063602.GG11812@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
On Thu, Jul 12, 2012 at 06:19:29PM +0200, walter harms wrote:
> > if (ret != 0) {
> > dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> > + mutex_unlock(&info->lock);
> > return IRQ_NONE;
> normally you unlock before dev_err() and is the msg ok ?
No, that's really unusual as it can make the trace much harder to follow
if there's any contention.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-12 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 6:36 [patch] Extcon: Arizona: unlock on an error in arizona_micdet() Dan Carpenter
2012-07-11 6:36 ` Dan Carpenter
2012-07-11 23:55 ` Chanwoo Choi
2012-07-11 23:55 ` Chanwoo Choi
2012-07-12 16:19 ` walter harms
2012-07-12 16:24 ` Dan Carpenter
2012-07-12 17:27 ` Mark Brown [this message]
2012-07-12 17:30 ` Mark Brown
2012-07-12 17:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712172725.GA9270@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.