From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 01/10] f81232: correct stubbed termios handler
Date: Thu, 12 Jul 2012 14:36:02 -0700 [thread overview]
Message-ID: <20120712213602.GA11567@kroah.com> (raw)
In-Reply-To: <20120712115848.1321.12293.stgit@localhost.localdomain>
On Thu, Jul 12, 2012 at 12:58:55PM +0100, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/usb/serial/f81232.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 499b15f..acd3267 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
> @@ -177,6 +177,7 @@ static void f81232_set_termios(struct tty_struct *tty,
> return;
>
> /* Do the real work here... */
> + tty_termios_copy_hw(&tty->termios, old_termios);
Drop the '&' and the code will compile correctly.
Otherwise, it's wrong :(
greg k-h
next prev parent reply other threads:[~2012-07-12 21:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 11:58 [PATCH 00/10] Resend: tty updates Alan Cox
2012-07-12 11:58 ` [PATCH 01/10] f81232: correct stubbed termios handler Alan Cox
2012-07-12 21:36 ` Greg KH [this message]
2012-07-12 11:59 ` [PATCH 02/10] usb: fix sillies in the metro USB driver Alan Cox
2012-07-12 11:59 ` [PATCH 03/10] usb, kobil: Sort out some bogus tty handling Alan Cox
2012-07-12 21:38 ` Greg KH
2012-07-12 11:59 ` [PATCH 04/10] 8250: use the 8250 register interface not the legacy one Alan Cox
2012-07-12 12:00 ` [PATCH 05/10] 8250: propogate the bugs field Alan Cox
2012-07-12 12:00 ` [PATCH 06/10] 8250: add support for ASIX devices with a FIFO bug Alan Cox
2012-07-12 12:01 ` [PATCH 08/10] tty: tidy up the RESET_TERMIOS case Alan Cox
2012-07-12 12:01 ` [PATCH 09/10] vt: fix the keyboard/led locking Alan Cox
2012-07-12 12:01 ` [PATCH 10/10] tty: Move the handling of the tty release logic Alan Cox
2012-07-12 21:35 ` [PATCH 00/10] Resend: tty updates Greg KH
2012-07-12 23:16 ` Alan Cox
[not found] ` <20120712120042.1321.81017.stgit@localhost.localdomain>
2012-07-12 21:53 ` [PATCH 07/10] tty: move the termios object into the tty Greg KH
2012-07-12 23:43 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712213602.GA11567@kroah.com \
--to=greg@kroah.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.