From: Andrew Morton <akpm@linux-foundation.org>
To: dedekind1@gmail.com
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Evgeniy Dushistov <dushistov@mail.ru>,
Linux FS Maling List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt
Date: Thu, 12 Jul 2012 22:45:38 -0700 [thread overview]
Message-ID: <20120712224538.31cb1e18.akpm@linux-foundation.org> (raw)
In-Reply-To: <1342157684.23418.6.camel@brekeke>
On Fri, 13 Jul 2012 08:34:44 +0300 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Thu, 2012-07-12 at 15:58 -0700, Andrew Morton wrote:
> > Just fix them up as you go - the code is already a mixture of "right"
> > and "wrong" (a consequence of a lot of it being "wrong") - we might as
> > well tip it further in the "right" direction.
>
> Yeah, but I'd say 80% of it has its own "wrong" coding style, so fixing
> it is a separate patch-set. Simply because when I partially fix it,
> there are almost always context lines which upset checkpatch.pl, so I
> would need to fix it all. I can easily clean it up a bit separately,
> just let me know if you want me to do this.
checkpatch does not report on context lines - only on added lines.
next prev parent reply other threads:[~2012-07-13 5:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 13:28 [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Artem Bityutskiy
2012-07-12 13:28 ` [PATCH 1/3] fs/ufs: remove extra superblock write on unmount Artem Bityutskiy
2012-07-12 13:28 ` [PATCH 2/3] fs/ufs: re-arrange the code a bit Artem Bityutskiy
2012-07-12 13:28 ` [PATCH 3/3] fs/ufs: get rid of write_super Artem Bityutskiy
2012-07-12 22:58 ` [PATCH 0/3] fs/ufs: stop using write_supers and s_dirt Andrew Morton
2012-07-13 5:34 ` Artem Bityutskiy
2012-07-13 5:45 ` Andrew Morton [this message]
2012-07-13 5:47 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120712224538.31cb1e18.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dedekind1@gmail.com \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.