From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Date: Thu, 12 Jul 2012 16:36:45 -0700 Message-ID: <20120712233645.GG20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> <20120712170519.GA20167@google.com> <20120712214514.GD20167@google.com> <20120712223221.GF20167@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Fengguang Wu , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, joshhunt00@gmail.com, axboe@kernel.dk, rni@google.com, vgoyal@redhat.com, vwadekar@nvidia.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, swhiteho@redhat.com, bpm@sgi.com, elder@kernel.org, xfs@oss.sgi.com, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, martin.petersen@oracle.com To: Tony Luck Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Hello, Tony. On Thu, Jul 12, 2012 at 04:24:47PM -0700, Tony Luck wrote: > On Thu, Jul 12, 2012 at 3:32 PM, Tejun Heo wrote: > > Can you please try the following debug patch instead? Yours is > > different from Fengguang's. > > New dmesg from mext-20120712 + this new patch (instead of previous one) > > [Note - I see some XXX traces, but no WARN_ON stack dump this time] The debug patch didn't do anything for the bug itself. I suppose it's timing dependent and doesn't always happen (it never reproduces here for some reason). Can you please repeat several times and see whether the warning can be triggered? Thank you very much! -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q6CNapgf091803 for ; Thu, 12 Jul 2012 18:36:51 -0500 Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53]) by cuda.sgi.com with ESMTP id 59jDVn03huTVUCRK (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Thu, 12 Jul 2012 16:36:50 -0700 (PDT) Received: by yhp26 with SMTP id 26so3794093yhp.26 for ; Thu, 12 Jul 2012 16:36:50 -0700 (PDT) Date: Thu, 12 Jul 2012 16:36:45 -0700 From: Tejun Heo Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Message-ID: <20120712233645.GG20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> <20120712170519.GA20167@google.com> <20120712214514.GD20167@google.com> <20120712223221.GF20167@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Tony Luck Cc: axboe@kernel.dk, xfs@oss.sgi.com, elder@kernel.org, rni@google.com, martin.petersen@oracle.com, linux-bluetooth@vger.kernel.org, torvalds@linux-foundation.org, marcel@holtmann.org, linux-kernel@vger.kernel.org, vwadekar@nvidia.com, swhiteho@redhat.com, herbert@gondor.hengli.com.au, bpm@sgi.com, linux-crypto@vger.kernel.org, gustavo@padovan.org, Fengguang Wu , joshhunt00@gmail.com, davem@davemloft.net, vgoyal@redhat.com, johan.hedberg@gmail.com Hello, Tony. On Thu, Jul 12, 2012 at 04:24:47PM -0700, Tony Luck wrote: > On Thu, Jul 12, 2012 at 3:32 PM, Tejun Heo wrote: > > Can you please try the following debug patch instead? Yours is > > different from Fengguang's. > > New dmesg from mext-20120712 + this new patch (instead of previous one) > > [Note - I see some XXX traces, but no WARN_ON stack dump this time] The debug patch didn't do anything for the bug itself. I suppose it's timing dependent and doesn't always happen (it never reproduces here for some reason). Can you please repeat several times and see whether the warning can be triggered? Thank you very much! -- tejun _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161841Ab2GLXgz (ORCPT ); Thu, 12 Jul 2012 19:36:55 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:63399 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161720Ab2GLXgv (ORCPT ); Thu, 12 Jul 2012 19:36:51 -0400 Date: Thu, 12 Jul 2012 16:36:45 -0700 From: Tejun Heo To: Tony Luck Cc: Fengguang Wu , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, joshhunt00@gmail.com, axboe@kernel.dk, rni@google.com, vgoyal@redhat.com, vwadekar@nvidia.com, herbert@gondor.hengli.com.au, davem@davemloft.net, linux-crypto@vger.kernel.org, swhiteho@redhat.com, bpm@sgi.com, elder@kernel.org, xfs@oss.sgi.com, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org, martin.petersen@oracle.com Subject: Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool Message-ID: <20120712233645.GG20167@google.com> References: <1341859315-17759-7-git-send-email-tj@kernel.org> <20120712130648.GA19214@localhost> <20120712170519.GA20167@google.com> <20120712214514.GD20167@google.com> <20120712223221.GF20167@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Tony. On Thu, Jul 12, 2012 at 04:24:47PM -0700, Tony Luck wrote: > On Thu, Jul 12, 2012 at 3:32 PM, Tejun Heo wrote: > > Can you please try the following debug patch instead? Yours is > > different from Fengguang's. > > New dmesg from mext-20120712 + this new patch (instead of previous one) > > [Note - I see some XXX traces, but no WARN_ON stack dump this time] The debug patch didn't do anything for the bug itself. I suppose it's timing dependent and doesn't always happen (it never reproduces here for some reason). Can you please repeat several times and see whether the warning can be triggered? Thank you very much! -- tejun