From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support Date: Fri, 13 Jul 2012 03:03:46 +0300 Message-ID: <20120713000346.GB9614@redhat.com> References: <20120701150830.GA31443@redhat.com> <4FFBEA5D.7080104@redhat.com> <20120710125508.GE13348@otherpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dor Laor , Marcelo Tosatti , avi@redhat.com, kvm@vger.kernel.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Igor Mammedov , Michael Roth , Anthony Liguori , gleb@redhat.com To: Eduardo Habkost Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790Ab2GMADh (ORCPT ); Thu, 12 Jul 2012 20:03:37 -0400 Content-Disposition: inline In-Reply-To: <20120710125508.GE13348@otherpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jul 10, 2012 at 09:55:08AM -0300, Eduardo Habkost wrote: > On Tue, Jul 10, 2012 at 11:39:57AM +0300, Dor Laor wrote: > > On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote: > > >Support the new PV EOI flag in kvm - it recently got merged > > >into kvm.git. Set by default with -cpu kvm. > > >Set for -cpu qemu by adding +kvm_pv_eoi. > > >Clear by adding -kvm_pv_eoi to -cpu option. > > > > What about adding them to our cpu models? > > It should go w/o saying for all models (SandyBridge, OpteronGx,..) > > but there is the issue of backward compat. I remember we had a > > discussion about pair the models w/ the current machine type (-M) but > > I don't remember the final call. > > > > What's your take Eduardo? > > We can really add it, but only after adding the infra-structure to allow > "versioned" CPU models (with per-machine-type aliases for backwards > compatibility with older machine types). > > (The current status of this is "I am going to implement it", but there's > no code do do that yet). OK so I'll just wait and you'll make it happen? Also is libvirt support needed? > > > > Cheers, > > Dor > > > > > > > >Signed-off-by: Michael S. Tsirkin > > >--- > > > > > >Changes from v1: > > > rebased to uq/master > > > > > > target-i386/cpu.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > >index 5521709..ee1b64a 100644 > > >--- a/target-i386/cpu.c > > >+++ b/target-i386/cpu.c > > >@@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = { > > > }; > > > > > > static const char *kvm_feature_name[] = { > > >- "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL, > > >+ "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL, > > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, > > > > > > > > > -- > Eduardo