All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Rob Landley <rob@landley.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	rgetz@blackfin.uclinux.org, mpm@selenic.com
Subject: Re: feature-removal-schedule entry from 2009
Date: Thu, 12 Jul 2012 23:03:25 -0400	[thread overview]
Message-ID: <20120713030325.GB12245@thunk.org> (raw)
In-Reply-To: <4FFDA698.2000707@landley.net>

On Wed, Jul 11, 2012 at 11:15:20AM -0500, Rob Landley wrote:
> IRQF_SAMPLE_RANDOM is 3 years past its sell-by date in
> feature-removal-schedule:
> 
> What:   IRQF_SAMPLE_RANDOM
> Check:  IRQF_SAMPLE_RANDOM
> When:   July 2009
> 
> Why:    Many of IRQF_SAMPLE_RANDOM users are technically bogus as
>         entropy sources in the kernel's current entropy model. To
>         resolve this, every input point to the kernel's entropy pool
>         needs to better document the type of entropy source it actually
>         is. This will be replaced with additional add_*_randomness
>         functions in drivers/char/random.c
> 
> Who:    Robin Getz <rgetz@blackfin.uclinux.org>
>         & Matt Mackall <mpm@selenic.com>
> 
> There are 12 remaining uses under drivers/ and 14 more under arch/, the
> rest of the hits look like infrastructure implementing it.
> 
> Should I run those files through bother-maintainer.pl and try to get
> people to stop it, or is there a plan underway I don't know about?

I was going to deal with that in the new /dev/random tree; once those
changes go in, IRQF_SAMPLE_RANDOM effectively becomes a no-op.  But
I'd prefer that the ordering be that we get the new
sample_interrupt_randomness() changes in first, and then remove the
IRQF_SAMPLE_RANDOM.

I've just been slammed with work, processing patches for the ext4
merge window, and kernel summit planning, and quite frankly, I
considered this to be relatively low priority --- especially since we
no shortage of IRQF_* flag bits, and once the new
sample_interrupt_randomness() goes in, the flag is a complete no-op.

			      	       	   	- Ted

  reply	other threads:[~2012-07-13  3:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 16:15 feature-removal-schedule entry from 2009 Rob Landley
2012-07-13  3:03 ` Theodore Ts'o [this message]
2012-07-15 20:41   ` Rob Landley
2012-07-16 15:21     ` Theodore Ts'o
2012-07-17 17:19       ` [uml-devel] " Rob Landley
2012-07-17 21:29         ` Theodore Ts'o
2012-07-17 22:29           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120713030325.GB12245@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.