From: NeilBrown <neilb@suse.de>
To: Karel Zak <kzak@redhat.com>
Cc: Steve Dickson <SteveD@redhat.com>, NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] umount.nfs: restore correct error status when umount fails.
Date: Fri, 13 Jul 2012 06:16:37 +1000 [thread overview]
Message-ID: <20120713061637.4fe40294@notabene.brown> (raw)
In-Reply-To: <20120712164420.GA15398@x2.net.home>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Thu, 12 Jul 2012 18:44:20 +0200 Karel Zak <kzak@redhat.com> wrote:
> > This patch restores the use of EX_FILEIO for errors from umount.
>
> Looks good to me.
>
> Reviewed-by: Karel Zak <kzak@redhat.com>
>
> > There is a case that I know it doesn't handle. If you ask umount.nfs to
> > unmount a filesystem that is not nfs or nfs4, then the old code will
> > refuse
> > umount.nfs: /dev/sda7 on /mnt2 is not an NFS filesystem
> >
> > and exit with status '1'.
> > The new libmount code will just think that it couldn't find anything in
> > fstab and will try to do an nfs23 unmount. This is clearly different behaviour,
> > I'm not sure that anyone would care though.
>
> I care, it's stupid bug to use umount.nfs for non-NFS filesytems. The
> patch below fixes this issue.
>
Cool - thanks for that!
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2012-07-12 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 3:27 [PATCH] umount.nfs: restore correct error status when umount fails NeilBrown
2012-07-12 16:44 ` Karel Zak
2012-07-12 20:16 ` NeilBrown [this message]
2012-07-16 12:57 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713061637.4fe40294@notabene.brown \
--to=neilb@suse.de \
--cc=SteveD@redhat.com \
--cc=kzak@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.