From: Dan Carpenter <dan.carpenter@oracle.com>
To: johannes.berg@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: mac80211: optimize ieee80211_rx_status struct layout
Date: Fri, 13 Jul 2012 11:52:27 +0300 [thread overview]
Message-ID: <20120713085227.GA16445@elgon.mountain> (raw)
Hello Johannes Berg,
The patch 30f422925c39: "mac80211: optimize ieee80211_rx_status
struct layout" from Jul 5, 2012, leads to the following warning:
drivers/net/wireless/b43/xmit.c:773 b43_rx()
error: status.rate_idx is never equal to -1 (wrong type 0 - 255).
drivers/net/wireless/b43/xmit.c
768 if (phystat0 & B43_RX_PHYST0_OFDM)
769 status.rate_idx = b43_plcp_get_bitrate_idx_ofdm(plcp,
770 phytype == B43_PHYTYPE_A);
771 else
772 status.rate_idx = b43_plcp_get_bitrate_idx_cck(plcp);
773 if (unlikely(status.rate_idx == -1)) {
774 /* PLCP seems to be corrupted.
775 * Drop the frame, if we are not interested in corrupted frames. */
776 if (!(dev->wl->filter_flags & FIF_PLCPFAIL))
777 goto drop;
778 }
b43_plcp_get_bitrate_idx_ofdm() and b43_plcp_get_bitrate_idx_cck()
return -1 on error. The "rate_idx" variable used to be an int but now
it's a u8.
regards,
dan carpenter
next reply other threads:[~2012-07-13 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 8:52 Dan Carpenter [this message]
2012-07-13 8:54 ` mac80211: optimize ieee80211_rx_status struct layout Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713085227.GA16445@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.