From: Andi Kleen <ak@linux.intel.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@gmail.com>,
linux-kernel@vger.kernel.org,
"Jonathan M. Foote" <jmfoote@cert.org>,
"H. J. Lu" <hjl.tools@gmail.com>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH v2] Extend core dump note section to contain file names of mapped files
Date: Fri, 13 Jul 2012 08:56:32 -0700 [thread overview]
Message-ID: <20120713155632.GA30239@tassilo.jf.intel.com> (raw)
In-Reply-To: <20120713145806.GA17217@redhat.com>
On Fri, Jul 13, 2012 at 04:58:06PM +0200, Oleg Nesterov wrote:
> On 07/12, Denys Vlasenko wrote:
> >
> > This note has the following format:
> >
> > long count -- how many files are mapped
> > long page_size -- units for file_ofs
> > array of [COUNT] elements of
> > long start
> > long end
> > long file_ofs
> > followed by COUNT filenames in ASCII: "FILE1" NUL "FILE2" NUL...
>
> All I can say, I believe the patch is correct.
Patch looks good to me too.
> Otherwise I can't comment the patch, I simply do not know what
> people do with the coredumps. But Denys certainly knows, he works
> with the tools which need this info.
More information during debugging is always good.
I assume there will be a gdb patch to dump it?
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-07-13 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 19:42 [PATCH v2] Extend core dump note section to contain file names of mapped files Denys Vlasenko
2012-07-13 14:58 ` Oleg Nesterov
2012-07-13 15:56 ` Andi Kleen [this message]
2012-07-13 17:20 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713155632.GA30239@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jan.kratochvil@redhat.com \
--cc=jmfoote@cert.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=vda.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.