From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"J. Bruce Fields" <bfields@redhat.com>
Subject: Re: Remove easily user-triggerable BUG from generic_setlease
Date: Fri, 13 Jul 2012 13:50:31 -0400 [thread overview]
Message-ID: <20120713175030.GA8911@redhat.com> (raw)
In-Reply-To: <CA+55aFyg7Cs5KF4HGQKAUi29+RpXJdUyEm6uy57rwVBB_jyN3Q@mail.gmail.com>
On Fri, Jul 13, 2012 at 10:47:43AM -0700, Linus Torvalds wrote:
> On Fri, Jul 13, 2012 at 10:35 AM, Dave Jones <davej@redhat.com> wrote:
> > This can be trivially triggered from userspace by passing in something unexpected.
>
> Argh. It looks like it would be harmless (apart from the noise),
> except we hold file_lock_lock. Which turns the BUG_ON() into not just
> "noise and kill the process", but "noise and kill the process and
> leave a nasty lock held".
Yeah, box wedged shortly afterwards. Not cool.
> This seems to go back to 3.2, so stable should be cc'd, no?
yeah, definitly. my bad.
Dave
next prev parent reply other threads:[~2012-07-13 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 17:35 Remove easily user-triggerable BUG from generic_setlease Dave Jones
2012-07-13 17:47 ` Linus Torvalds
2012-07-13 17:50 ` Dave Jones [this message]
2012-07-23 15:20 ` J. Bruce Fields
2012-07-23 18:34 ` Linus Torvalds
2012-07-23 19:04 ` J. Bruce Fields
2012-07-23 19:09 ` Linus Torvalds
2012-07-23 19:17 ` [PATCH] locks: fix checking of fcntl_setlease argument J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120713175030.GA8911@redhat.com \
--to=davej@redhat.com \
--cc=bfields@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.