Re: [PATCH] libnetfilter_queue: Implement API to set per-queue flags

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Jun 06, 2012 at 04:29:00PM +0530, Krishna Kumar wrote:
> Implement API to set per-queue flags. This is initially used
> to implement fail-open support in NFQUEUE.

Applied with minor spots (see below), thanks.

> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
> ---
>  include/libnetfilter_queue/libnetfilter_queue.h    |    3 
>  include/libnetfilter_queue/linux_nfnetlink_queue.h |    5 +
>  src/libnetfilter_queue.c                           |   42 +++++++++++
>  3 files changed, 50 insertions(+)
> 
> diff -ruNp org/include/libnetfilter_queue/libnetfilter_queue.h new/include/libnetfilter_queue/libnetfilter_queue.h
> --- org/include/libnetfilter_queue/libnetfilter_queue.h	2012-06-06 10:07:21.863540677 +0530
> +++ new/include/libnetfilter_queue/libnetfilter_queue.h	2012-06-06 10:08:17.629962800 +0530
> @@ -56,6 +56,9 @@ extern int nfq_set_mode(struct nfq_q_han
>  int nfq_set_queue_maxlen(struct nfq_q_handle *qh,
>  			u_int32_t queuelen);
>  
> +extern int nfq_set_queue_flags(struct nfq_q_handle *qh,
> +			       uint32_t mask, uint32_t flags);
> +
>  extern int nfq_set_verdict(struct nfq_q_handle *qh,
>  			     u_int32_t id,
>  			     u_int32_t verdict,
> diff -ruNp org/include/libnetfilter_queue/linux_nfnetlink_queue.h new/include/libnetfilter_queue/linux_nfnetlink_queue.h
> --- org/include/libnetfilter_queue/linux_nfnetlink_queue.h	2012-06-06 10:07:21.874538295 +0530
> +++ new/include/libnetfilter_queue/linux_nfnetlink_queue.h	2012-06-06 15:41:51.912636134 +0530
> @@ -87,8 +87,13 @@ enum nfqnl_attr_config {
>  	NFQA_CFG_CMD,			/* nfqnl_msg_config_cmd */
>  	NFQA_CFG_PARAMS,		/* nfqnl_msg_config_params */
>  	NFQA_CFG_QUEUE_MAXLEN,		/* u_int32_t */
> +	NFQA_CFG_MASK,			/* identify which flags to change */
> +	NFQA_CFG_FLAGS,			/* value of these flags (__u32) */
>  	__NFQA_CFG_MAX
>  };
>  #define NFQA_CFG_MAX (__NFQA_CFG_MAX-1)
>  
> +/* Flags/options for NFQA_CFG_FLAGS */
> +#define NFQA_CFG_F_FAIL_OPEN		(1 << 0)

added NFQA_CFG_F_CONNTRACK and _MAX.

I've also bumped LIBVERSION.