From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jason Cooper <jason@lakedaemon.net>,
sebastian.hesselbarth@googlemail.com, w.sang@pengutronix.de,
linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCHv3] I2C: MV64XXX: Add Device Tree support
Date: Mon, 16 Jul 2012 14:20:19 +0200 [thread overview]
Message-ID: <20120716142019.3f6cdc26@skate> (raw)
In-Reply-To: <1342430205-13702-2-git-send-email-andrew@lunn.ch>
Le Mon, 16 Jul 2012 11:16:45 +0200,
Andrew Lunn <andrew@lunn.ch> a écrit :
> + - reg : Offset and length of the register set for the device
> + - compatible : Should be "marvell,mv64xxx-i2c"
> + - interrupts : Te interrupt number
The
> + i2c@11000 {
> + compatible = "marvell,mv64xxx-i2c";
> + reg = <0x11000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <29>;
> + clock-frequency = <400000>;
> + timeout-ms = <1000>;
> + status = "disable";
This should be "disabled". Any other status than "okay" is considered
as disabled, if I'm correct, but the right opposite to "okay" is
"disabled", as far as I'm aware.
The #ifdef machinery in the ->probe() function looks a bit ugly, but I
guess this can be cleaned up once all platforms using this driver will
have been converted to DT + clock framework.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] I2C: MV64XXX: Add Device Tree support
Date: Mon, 16 Jul 2012 14:20:19 +0200 [thread overview]
Message-ID: <20120716142019.3f6cdc26@skate> (raw)
In-Reply-To: <1342430205-13702-2-git-send-email-andrew@lunn.ch>
Le Mon, 16 Jul 2012 11:16:45 +0200,
Andrew Lunn <andrew@lunn.ch> a ?crit :
> + - reg : Offset and length of the register set for the device
> + - compatible : Should be "marvell,mv64xxx-i2c"
> + - interrupts : Te interrupt number
The
> + i2c at 11000 {
> + compatible = "marvell,mv64xxx-i2c";
> + reg = <0x11000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <29>;
> + clock-frequency = <400000>;
> + timeout-ms = <1000>;
> + status = "disable";
This should be "disabled". Any other status than "okay" is considered
as disabled, if I'm correct, but the right opposite to "okay" is
"disabled", as far as I'm aware.
The #ifdef machinery in the ->probe() function looks a bit ugly, but I
guess this can be cleaned up once all platforms using this driver will
have been converted to DT + clock framework.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-16 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:16 [PATCHv3] I2C: MV64XXX: Add Device Tree support Andrew Lunn
2012-07-16 9:16 ` Andrew Lunn
2012-07-16 9:16 ` Andrew Lunn
2012-07-16 9:16 ` Andrew Lunn
2012-07-16 12:20 ` Thomas Petazzoni [this message]
2012-07-16 12:20 ` Thomas Petazzoni
2012-07-16 12:37 ` Andrew Lunn
2012-07-16 12:37 ` Andrew Lunn
2012-07-20 10:35 ` Wolfram Sang
2012-07-20 10:35 ` Wolfram Sang
2012-07-20 11:17 ` Andrew Lunn
2012-07-20 11:17 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716142019.3f6cdc26@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.