From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCHv3] I2C: MV64XXX: Add Device Tree support Date: Mon, 16 Jul 2012 14:20:19 +0200 Message-ID: <20120716142019.3f6cdc26@skate> References: <1342430205-13702-1-git-send-email-andrew@lunn.ch> <1342430205-13702-2-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1342430205-13702-2-git-send-email-andrew@lunn.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Lunn Cc: Jason Cooper , sebastian.hesselbarth@googlemail.com, w.sang@pengutronix.de, linux ARM , linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org TGUgTW9uLCAxNiBKdWwgMjAxMiAxMToxNjo0NSArMDIwMCwKQW5kcmV3IEx1bm4gPGFuZHJld0Bs dW5uLmNoPiBhIMOpY3JpdCA6Cgo+ICsgLSByZWcgICAgICAgICAgICAgOiBPZmZzZXQgYW5kIGxl bmd0aCBvZiB0aGUgcmVnaXN0ZXIgc2V0IGZvciB0aGUgZGV2aWNlCj4gKyAtIGNvbXBhdGlibGUg ICAgICA6IFNob3VsZCBiZSAibWFydmVsbCxtdjY0eHh4LWkyYyIKPiArIC0gaW50ZXJydXB0cyAg ICAgIDogVGUgaW50ZXJydXB0IG51bWJlcgoKICAgICAgICAgICAgICAgICAgICAgICAgVGhlCgo+ ICsJCWkyY0AxMTAwMCB7Cj4gKwkJCWNvbXBhdGlibGUgPSAibWFydmVsbCxtdjY0eHh4LWkyYyI7 Cj4gKwkJCXJlZyA9IDwweDExMDAwIDB4MjA+Owo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsK PiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwkJCWludGVycnVwdHMgPSA8Mjk+Owo+ICsJCQlj bG9jay1mcmVxdWVuY3kgPSA8NDAwMDAwPjsKPiArCQkJdGltZW91dC1tcyA9IDwxMDAwPjsKPiAr CQkJc3RhdHVzID0gImRpc2FibGUiOwoKVGhpcyBzaG91bGQgYmUgImRpc2FibGVkIi4gQW55IG90 aGVyIHN0YXR1cyB0aGFuICJva2F5IiBpcyBjb25zaWRlcmVkCmFzIGRpc2FibGVkLCBpZiBJJ20g Y29ycmVjdCwgYnV0IHRoZSByaWdodCBvcHBvc2l0ZSB0byAib2theSIgaXMKImRpc2FibGVkIiwg YXMgZmFyIGFzIEknbSBhd2FyZS4KClRoZSAjaWZkZWYgbWFjaGluZXJ5IGluIHRoZSAtPnByb2Jl KCkgZnVuY3Rpb24gbG9va3MgYSBiaXQgdWdseSwgYnV0IEkKZ3Vlc3MgdGhpcyBjYW4gYmUgY2xl YW5lZCB1cCBvbmNlIGFsbCBwbGF0Zm9ybXMgdXNpbmcgdGhpcyBkcml2ZXIgd2lsbApoYXZlIGJl ZW4gY29udmVydGVkIHRvIERUICsgY2xvY2sgZnJhbWV3b3JrLgoKVGhvbWFzCi0tIApUaG9tYXMg UGV0YXp6b25pLCBGcmVlIEVsZWN0cm9ucwpLZXJuZWwsIGRyaXZlcnMsIHJlYWwtdGltZSBhbmQg ZW1iZWRkZWQgTGludXgKZGV2ZWxvcG1lbnQsIGNvbnN1bHRpbmcsIHRyYWluaW5nIGFuZCBzdXBw b3J0LgpodHRwOi8vZnJlZS1lbGVjdHJvbnMuY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Mon, 16 Jul 2012 14:20:19 +0200 Subject: [PATCHv3] I2C: MV64XXX: Add Device Tree support In-Reply-To: <1342430205-13702-2-git-send-email-andrew@lunn.ch> References: <1342430205-13702-1-git-send-email-andrew@lunn.ch> <1342430205-13702-2-git-send-email-andrew@lunn.ch> Message-ID: <20120716142019.3f6cdc26@skate> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le Mon, 16 Jul 2012 11:16:45 +0200, Andrew Lunn a ?crit : > + - reg : Offset and length of the register set for the device > + - compatible : Should be "marvell,mv64xxx-i2c" > + - interrupts : Te interrupt number The > + i2c at 11000 { > + compatible = "marvell,mv64xxx-i2c"; > + reg = <0x11000 0x20>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <29>; > + clock-frequency = <400000>; > + timeout-ms = <1000>; > + status = "disable"; This should be "disabled". Any other status than "okay" is considered as disabled, if I'm correct, but the right opposite to "okay" is "disabled", as far as I'm aware. The #ifdef machinery in the ->probe() function looks a bit ugly, but I guess this can be cleaned up once all platforms using this driver will have been converted to DT + clock framework. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com