From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] lua : refactor with POST_PATH_HOOKS
Date: Mon, 16 Jul 2012 17:46:22 +0200 [thread overview]
Message-ID: <20120716174622.6ea0ffea@skate> (raw)
In-Reply-To: <1342446352-31231-4-git-send-email-francois.perrad@gadz.org>
Le Mon, 16 Jul 2012 15:45:51 +0200,
Francois Perrad <fperrad@gmail.com> a ?crit :
> +define LUA_PREFIX_FIX_PKG_CONFIG
> + $(SED) 's/\/usr\/local/\/usr/' $(@D)/etc/lua.pc
> +endef
> +LUA_POST_PATCH_HOOKS += LUA_PREFIX_FIX_PKG_CONFIG
> +HOST_LUA_POST_PATCH_HOOKS += LUA_PREFIX_FIX_PKG_CONFIG
> +
> +define LUA_OPTIM_FIX_MAKEFILE
> + $(SED) 's/-O2//' $(@D)/src/Makefile
> +endef
> +LUA_POST_PATCH_HOOKS += LUA_OPTIM_FIX_MAKEFILE
> +HOST_LUA_POST_PATCH_HOOKS += LUA_OPTIM_FIX_MAKEFILE
It sounds odd to me to have a patch to fix the /usr prefix in
src/luaconf.h on one side, and on the other side, fix other problems by
using sed in the .mk file. Either one or the other, but not both in the
same package.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-16 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 13:45 [Buildroot] [PATCH 1/5] lua : fix autobuild.buildroot Francois Perrad
2012-07-16 13:45 ` [Buildroot] [PATCH 2/5] lua : don't install static library in target Francois Perrad
2012-07-16 15:41 ` Thomas Petazzoni
2012-07-16 13:45 ` [Buildroot] [PATCH 3/5] lua : don't install shared library in staging Francois Perrad
2012-07-16 15:44 ` Thomas Petazzoni
2012-07-16 13:45 ` [Buildroot] [PATCH 4/5] lua : refactor with POST_PATH_HOOKS Francois Perrad
2012-07-16 15:46 ` Thomas Petazzoni [this message]
2012-07-16 13:45 ` [Buildroot] [PATCH 5/5] lua: split and rename patches Francois Perrad
2012-07-16 15:47 ` Thomas Petazzoni
2012-07-16 15:39 ` [Buildroot] [PATCH 1/5] lua : fix autobuild.buildroot Thomas Petazzoni
2012-07-17 8:35 ` François Perrad
2012-07-17 8:40 ` Thomas Petazzoni
2012-07-17 14:46 ` [Buildroot] [UNSURE]Re: " François Perrad
2012-07-17 14:57 ` Thomas Petazzoni
2012-07-17 15:20 ` [Buildroot] [UNSURE]Re: " François Perrad
2012-07-17 21:35 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716174622.6ea0ffea@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.