Re: [RFC][meta-oe][PATCH 3/3] blacklist.bbclass: Move to meta-angstrom

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2826 bytes --]

On Mon, Jul 16, 2012 at 10:50:58AM -0700, Khem Raj wrote:
> On Mon, Jul 16, 2012 at 10:46 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Mon, Jul 16, 2012 at 10:38:36AM -0700, Khem Raj wrote:
> >> This class is angstrom specific so lets move it to more
> >> appropriate layer
> >
> > This is also used by SHR, that's why I've asked Koen to move blacklist
> > from meta-angstrom to meta-oe before
> > http://git.openembedded.org/meta-openembedded/commit/?id=68c15845d087df0a6f66c58a9fd80548a9bb3a59
> >
> 
> OK, OE-Core also has blacklist implementation. Have you given a
> thought to use it ?

Yes, but that would require distro config to be updated from
ANGSTROM_BLACKLIST_PN to PNBLACKLIST[pn] at the same time this class is
moved or duplicate all blacklist entries now and then remove
ANGSTROM_BLACKLIST_PN after it's moved..

Cheers,

> 
> > Cheers,
> >
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  meta-oe/classes/blacklist.bbclass |   20 --------------------
> >>  1 file changed, 20 deletions(-)
> >>  delete mode 100644 meta-oe/classes/blacklist.bbclass
> >>
> >> diff --git a/meta-oe/classes/blacklist.bbclass b/meta-oe/classes/blacklist.bbclass
> >> deleted file mode 100644
> >> index 7bf4a73..0000000
> >> --- a/meta-oe/classes/blacklist.bbclass
> >> +++ /dev/null
> >> @@ -1,20 +0,0 @@
> >> -# anonymous support class from angstrom
> >> -#
> >> -# Features:
> >> -#
> >> -# * blacklist handling, set ANGSTROM_BLACKLIST_pn-blah = "message"
> >> -#
> >> -
> >> -python () {
> >> -    import bb
> >> -
> >> -    blacklist = bb.data.getVar("ANGSTROM_BLACKLIST", d, 1)
> >> -    pkgnm = bb.data.getVar("PN", d, 1)
> >> -    distro = bb.data.getVar("DISTRO", d, 1)
> >> -
> >> -    if blacklist:
> >> -     bb.note("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist))
> >> -        raise bb.parse.SkipPackage("%s DOES NOT support %s because %s" % (distro,pkgnm, blacklist))
> >> -
> >> -}
> >> -
> >> --
> >> 1.7.9.5
> >>
> >>
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]