All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org, abbotti@mev.co.uk
Subject: Re: [PATCH] staging: comedi: adl_pci6208: use the comedi_device hw_dev to hold the pci_dev
Date: Mon, 16 Jul 2012 19:30:50 -0700	[thread overview]
Message-ID: <20120717023050.GA3025@kroah.com> (raw)
In-Reply-To: <201207161926.22725.hartleys@visionengravers.com>

On Mon, Jul 16, 2012 at 07:26:22PM -0700, H Hartley Sweeten wrote:
> Use the 'struct device *hw_dev' variable in the comedi_device struct
> to hold the pci_dev instead of carrying it in the private data.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/staging/comedi/drivers/adl_pci6208.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

Looks good to me, I forgot we had the to_pci_dev() macro in pci.h.  Want
to redo all of these and resend this one with the larger series?

thanks,

greg k-h

  reply	other threads:[~2012-07-17  2:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17  2:26 [PATCH] staging: comedi: adl_pci6208: use the comedi_device hw_dev to hold the pci_dev H Hartley Sweeten
2012-07-17  2:30 ` Greg KH [this message]
2012-07-17  2:32   ` H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120717023050.GA3025@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.