From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs: re-enable xfsaild idle mode and fix associated races
Date: Tue, 17 Jul 2012 03:00:00 -0400 [thread overview]
Message-ID: <20120717065959.GA29748@infradead.org> (raw)
In-Reply-To: <4FF1A74C.1070003@redhat.com>
On Mon, Jul 02, 2012 at 09:51:08AM -0400, Brian Foster wrote:
> Right... if we wanted to move this back into xfsaild_push(), the only
> way I can see doing that correctly is to move the task state logic down
> into that function as well, at which point the idle logic is now spread
> across two functions. :/
>
> Considering this patch introduces an independent check for the idle
> logic from the timeout logic (i.e., we use xfs_ail_min() now instead of
> the general scan state of xfsaild_push()), I personally find the
> separation of idle from timeout to be a bit more clear, but of course
> I'll try to implement whatever is most agreeable...
Let's take the patch as-is for 3.6 as we have enough other work in that
area queued. We can clean it up later if needed.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-17 7:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 10:52 [PATCH v3] xfs: re-enable xfsaild idle mode and fix associated races Brian Foster
2012-07-02 0:07 ` Dave Chinner
2012-07-02 13:33 ` Brian Foster
2012-07-02 23:51 ` Dave Chinner
2012-07-03 13:13 ` Brian Foster
2012-07-03 16:07 ` Christoph Hellwig
2012-07-02 7:05 ` Christoph Hellwig
2012-07-02 8:29 ` Dave Chinner
2012-07-02 13:51 ` Brian Foster
2012-07-17 7:00 ` Christoph Hellwig [this message]
2012-07-24 13:22 ` Christoph Hellwig
2012-07-24 14:54 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717065959.GA29748@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.