All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ] mgmt-api: Broadcaster/Observer management API
Date: Tue, 17 Jul 2012 11:44:17 +0300	[thread overview]
Message-ID: <20120717084417.GA1097@x220> (raw)
In-Reply-To: <1342038888-10102-2-git-send-email-anderson.lizardo@openbossa.org>

Hi Lizardo,

On Wed, Jul 11, 2012, Anderson Lizardo wrote:
> +Set Controller Data Command
> +===========================
> +
> +	Command Code:		0x002B
> +	Controller Index:	<controller id>
> +	Command Parameters:	Flags (1 Octet)
> +				Data_Type (1 Octet)
> +				Data_Length (1 Octet)
> +				Data (0-255 Octets)
> +	Return Parameters:
> +

The return parameters should include the Flags and Data_Type so that
user space can distinguish which Set Controller Data command completed
or failed (in the case of multiple pending commands). Same goes for the
Remove Controller Data command.

> +	This command can be used to set AD for LE capable controllers or EIR
> +	for BR/EDR controllers. Multiple AD/EIR types can be configured by
> +	calling this command multiple times. If the data does not fit on a
> +	single AD/EIR on the controller, it will be rotated based on the "High
> +	priority" flag, so data with this flag set will stay longer over the
> +	air than those with this flag cleared.

I'm still struggling to see the usefulness or even the feasibility of a
meaningful rotation of data. Is there actually some place in the core
spec that implies or recommends that this be done? More importantly, is
there some place that states that the content of multiple different AD
packets from the same remote device should be considered in an
aggregated manner instead of considering each of them as a
unique/complete state of the remote device? If there's no such mention
there's nothing stopping devices from using the latter interpretation
and in such a case any kind of rotation could mess things up. Also the
fact that there exists short/incomplete variants of many AD types
(UUIDs, device name) seems to indicate that if any kind of compromising
mechanism should be used when trying to fit data, this is it.

Johan

  reply	other threads:[~2012-07-17  8:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 20:34 [RFC BlueZ] mgmt-api: Broadcaster/Observer management API Anderson Lizardo
2012-07-11 20:34 ` Anderson Lizardo
2012-07-17  8:44   ` Johan Hedberg [this message]
2012-07-17 17:58     ` Anderson Lizardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120717084417.GA1097@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.