All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Albrecht Dress <albrecht.dress@arcor.de>,
	Anatolij Gustschin <agust@denx.de>,
	linux-mtd@lists.infradead.org, stephan@gatzka.org,
	Stephan Gatzka <Stephan.Gatzka@hbm.com>
Subject: Re: [PATCH] mtd: physmap_of: Add "map-indirect" DT property
Date: Tue, 17 Jul 2012 11:56:45 +0200	[thread overview]
Message-ID: <201207171156.45375.sr@denx.de> (raw)
In-Reply-To: <1342471312.25411.30.camel@shinybook.infradead.org>

On Monday 16 July 2012 22:41:52 David Woodhouse wrote:
> On Sat, 2012-07-07 at 09:16 +0200, Stephan Gatzka wrote:
> > this patch works very well for us (of course, because Stefan made it for
> > us). Are there any concerns against it? Probably against introducing a
> > new DT property? Of course we can make this fix much more MPC5200
> > specific but this will result in largely copying physmap_of.c and some
> > additional code for access routines and Kconfig.
> 
> I don't much like the "map-indirect" name. If it's actually unaligned
> access, or non-word-sized access, that's forbidden, then that's what the
> DT property should be.
>
> The term "map-indirect" is more a description of how the software
> currently behaves... which is exactly that DT bindings *shouldn't* be.

Okay. I've chosen "map-indirect" because it might be used by other platforms 
as well, perhaps because of different reasons (so not restricting this to the 
unaligned access problem of the MPC5200). But I have no strong feelings here, 
so I can prepare a new patch version with a different name.

How about "no-unaligned-direct-access"? Pretty long though. Any other 
suggestions here?

Thanks,
Stefan

  reply	other threads:[~2012-07-17  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03  8:26 [PATCH] mtd: physmap_of: Add "map-indirect" DT property Stefan Roese
2012-07-07  7:16 ` Stephan Gatzka
2012-07-16 20:41   ` David Woodhouse
2012-07-17  9:56     ` Stefan Roese [this message]
2012-07-18  6:26       ` Artem Bityutskiy
2012-07-16  7:43 ` Anatolij Gustschin
2012-07-16 15:03 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207171156.45375.sr@denx.de \
    --to=sr@denx.de \
    --cc=Stephan.Gatzka@hbm.com \
    --cc=agust@denx.de \
    --cc=albrecht.dress@arcor.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=stephan@gatzka.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.