All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@amd.com>
To: Girish K S <girish.shivananjappa@linaro.org>,
	Chris Ball <cjb@laptop.org>
Cc: Philip Rakity <prakity@marvell.com>,
	linux-mmc@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH 2/2] mmc: sd: Fix sd current limit setting
Date: Tue, 17 Jul 2012 21:43:28 +0800	[thread overview]
Message-ID: <20120717134325.GA2567@localhost.localdomain> (raw)
In-Reply-To: <CAGxe1ZF=T7GL6ZcyV-=MEd5WVWexNrUbrEZDsYGdFD+KPH4XfA@mail.gmail.com>

On Tue, Jul 17, 2012 at 03:04:05PM +0530, Girish K S wrote:
> > @@ -261,6 +261,14 @@ struct mmc_host {
> >  #define MMC_CAP2_HC_ERASE_SZ   (1 << 9)        /* High-capacity erase size */
> >  #define MMC_CAP2_CD_ACTIVE_HIGH        (1 << 10)       /* Card-detect signal active high */
> >  #define MMC_CAP2_RO_ACTIVE_HIGH        (1 << 11)       /* Write-protect signal active high */
> > +#define MMC_CAP_MAX_CURRENT_200_300 (1 << 12)  /* Host max current limit is 200mA at 3.0V */
> > +#define MMC_CAP_MAX_CURRENT_400_300 (1 << 13)  /* Host max current limit is 400mA at 3.0V */
> > +#define MMC_CAP_MAX_CURRENT_600_300 (1 << 14)  /* Host max current limit is 600mA at 3.0V */
> > +#define MMC_CAP_MAX_CURRENT_800_300 (1 << 15)  /* Host max current limit is 800mA at 3.0V */
> > +#define MMC_CAP_MAX_CURRENT_200_330 (1 << 16)  /* Host max current limit is 200mA at 3.3V */
> > +#define MMC_CAP_MAX_CURRENT_400_330 (1 << 17)  /* Host max current limit is 400mA at 3.3V */
> > +#define MMC_CAP_MAX_CURRENT_600_330 (1 << 18)  /* Host max current limit is 600mA at 3.3V */
> > +#define MMC_CAP_MAX_CURRENT_800_330 (1 << 19)  /* Host max current limit is 800mA at 3.3V */
> sorry for seeing this late.
> The macro name should be **_CAP2_***.

Thanks for pointing this out, I'll be more careful next time.

> This is already merged in chris's mmc-next branch,
> Chris,
> Is it possible to change the macro name in the mmc-next branch for this patch?

Chris, please let me know how you want to deal with this and I'll be
glad to do whatever I can to fix this. Sorry for the trouble.

-Aaron

  reply	other threads:[~2012-07-17 13:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03  6:16 [PATCH 0/2] SD current limit setting fix Aaron Lu
2012-07-03  6:16 ` [PATCH 1/2] mmc: core: Simplify and fix for SD switch processing Aaron Lu
2012-07-04  0:48   ` Chris Ball
2012-07-03  6:16 ` [PATCH 2/2] mmc: sd: Fix sd current limit setting Aaron Lu
2012-07-03 14:18   ` Philip Rakity
2012-07-04  0:52   ` Chris Ball
2012-07-04  5:31     ` [PATCH v2 " Aaron Lu
2012-07-09  1:23       ` Philip Rakity
2012-07-10  2:57       ` Chris Ball
2012-07-17  9:34   ` [PATCH " Girish K S
2012-07-17 13:43     ` Aaron Lu [this message]
2012-07-17 15:43       ` Chris Ball
2012-07-18  5:09         ` Aaron Lu
2012-07-18  5:28           ` Chris Ball
2012-07-18  6:22             ` Aaron Lu
2012-07-19  2:41               ` Chris Ball
2012-07-19  3:47                 ` Philip Rakity
2012-07-19  6:25                 ` Chris Ball
2012-07-19  4:47               ` Girish K S
2012-07-19  5:03                 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120717134325.GA2567@localhost.localdomain \
    --to=aaron.lu@amd.com \
    --cc=aaron.lwe@gmail.com \
    --cc=cjb@laptop.org \
    --cc=girish.shivananjappa@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.