All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 00/12] ARM: Decompressor multiplatform support
Date: Tue, 17 Jul 2012 14:31:15 +0000	[thread overview]
Message-ID: <201207171431.16111.arnd@arndb.de> (raw)
In-Reply-To: <20120715024408.747946928@gmail.com>

On Sunday 15 July 2012, Domenico Andreoli wrote:
> My intent is to get rid of uncompress.h and prepare the decompressor
> to dynamically select the various machine specific decompressor init
> steps, included the selection of the appropriate console driver.
> 
> Currently the mainline kernel defines these steps statically and indeed
> has some trouble to boot on different boards with the same binary.
> 
> What this patch does is allowing the four functions (arch_decomp_setup,
> arch_error, putc and flush) currently used to define such static steps
> to be packed in quantity and to be selected/executed by the decompressor
> accordingly to the machid or DT passed by the boot loader.

I definitely like the implementation, it looks very nicely done with the
driver specific code being right inside of the actual device drivers.

I think the main question we have to answer is whether we want to go
this far for the decompressor output. IIRC the last time this was
debated, the argument was made (I don't remember if it was by Russell
or someone else) that the decompressor code is designed to be as simple
as possible and we should add too much complexity in it that would make
it harder to debug when the only purpose of that code is to debug the
decompressor code itself.

I find it hard to judge what the benefit of your implementation is
compared to the risk of introducing bugs.

The other part I don't understand is how it relates to the
early_print() infrastructure that has some of the same requirements.

	Arnd

  parent reply	other threads:[~2012-07-17 14:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-15  2:44 [RFC PATCH 00/12] ARM: Decompressor multiplatform support Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 01/12] ARM: Add strstr to the decompressor Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 02/12] ARM: kernel -> decompressor relocation handling Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 03/12] ARM: Add indirection around arch_decomp_setup()/arch_error() Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 04/12] ARM: Add architecture specific decompressor tags Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 05/12] ARM: Add DT support to " Domenico Andreoli
2012-07-17 14:14   ` Arnd Bergmann
2012-07-17 14:41     ` Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 06/12] ARM: Work around OMAPs arch_decomp_setup() Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 07/12] ARM: Add multi-arch console support to the decompressor Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 08/12] ARM: Add DT support to the decompressor console Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 09/12] ARM: Decompressor support for AMBA PL010 UARTs Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 10/12] ARM: Decompressor support for AMBA PL011 UARTs Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 11/12] ARM: Decompressor support for Samsung UARTs Domenico Andreoli
2012-07-15  2:44 ` [RFC PATCH 12/12] ARM: Decompressor support for OMAP UARTs Domenico Andreoli
2012-07-17 14:31 ` Arnd Bergmann [this message]
2012-07-17 14:54   ` [RFC PATCH 00/12] ARM: Decompressor multiplatform support Domenico Andreoli
  -- strict thread matches above, loose matches on Subject: below --
2012-07-19  3:48 shawn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207171431.16111.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.