From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [vfs:for-next 97/99] fs/ext3/dir.c:306:14: error: too few arguments to function 'generic_file_ll
Date: Tue, 17 Jul 2012 18:39:46 +0000 [thread overview]
Message-ID: <20120717183946.GS31729@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120716095850.GB18633@localhost>
On Tue, Jul 17, 2012 at 12:12:00PM -0500, Eric Sandeen wrote:
> On 7/16/12 11:45 AM, Al Viro wrote:
> > On Mon, Jul 16, 2012 at 10:44:03AM -0500, Eric Sandeen wrote:
> >> Thanks -
> >>
> >> I had sent "[PATCH 3/3] ext3: pass custom EOF to generic_file_llseek_size()" which I think should have fixed this up, along with "vfs: allow custom EOF in generic_file_llseek code"
> >>
> >> And, it is in Al's tree:
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/viro/vfs.git;a=commitdiff;h\x1073e38331024417f5b0c1fcf7af59b92fb92689
> >>
> >> as is the commit to make ext4 happy:
> >>
> >> http://git.kernel.org/?p=linux/kernel/git/viro/vfs.git;a=commitdiff;h¬5d776ddd7933c7aa9bb8fe2f9b3104dff659ca
> >
> > Yes, but it still creates a bisect hazard, so I'm going to fix that sucker up, along with
> > the similar mess in quota series. Will be in #for-next tomorrow.
> >
>
> Ok, sorry. My first proposed patch 1/3 would have been ok in this respect (it made a new function) but Matthew Wilcox suggested I change the existing function. And I took his advice. ;) Oh well.
*shrug*
Just needed to grep for other callers and make the trivial change in them,
in the same commit. Anyway, it's fixed in today's #for-next.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-07-17 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:58 [vfs:for-next 97/99] fs/ext3/dir.c:306:14: error: too few arguments to function 'generic_file_llseek Fengguang Wu
2012-07-16 15:44 ` [vfs:for-next 97/99] fs/ext3/dir.c:306:14: error: too few arguments to function 'generic_file_ll Eric Sandeen
2012-07-16 16:45 ` Al Viro
2012-07-17 17:12 ` Eric Sandeen
2012-07-17 18:39 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717183946.GS31729@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.