From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: sameo@linux.intel.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices
Date: Tue, 17 Jul 2012 20:14:51 +0100 [thread overview]
Message-ID: <20120717191451.GK4477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5004A409.9000002@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Tue, Jul 17, 2012 at 08:30:17AM +0900, Chanwoo Choi wrote:
> On 07/16/2012 10:36 PM, Mark Brown wrote:
> > On Mon, Jul 16, 2012 at 06:41:05PM +0900, Chanwoo Choi wrote:
> >> This patch fix bug related to interrupt handling for MAX77693 devices.
> >> - Unmask interrupt masking bit for charger/flash/muic to revolve
> >> that interrupt isn't happened when external connector is attached.
> > Shouldn't this be happening when the IRQ is requested?
> The interrupt isn't happened when external connector is attached
> because muic interrupt of MAX77693 is masked on INTSRC_MASK(
> Interrupt Source Mask) register. So, I should set zero to muic interrupt
> masking bit of INTSRC_MASK before requesting IRQ.
Right, but normally that unmasking happens in the unmask() callback of
the irq_chip which is called when the interrupt is requested. Why isn't
that working here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-17 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:41 [PATCH] mfd: MAX77693: Fix bug of interrupt handlding for MAX77693 devices Chanwoo Choi
2012-07-16 13:36 ` Mark Brown
2012-07-16 23:30 ` Chanwoo Choi
2012-07-17 19:14 ` Mark Brown [this message]
2012-07-18 0:50 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120717191451.GK4477@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.