From: Anton Vorontsov <cbouatmailru@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 04/17] pda_power: remove IRQF_SAMPLE_RANDOM which is now a no-op
Date: Tue, 17 Jul 2012 21:00:09 -0700 [thread overview]
Message-ID: <20120718040008.GA22599@lizard> (raw)
In-Reply-To: <1342560756-18737-5-git-send-email-tytso@mit.edu>
On Tue, Jul 17, 2012 at 05:32:23PM -0400, Theodore Ts'o wrote:
> With the changes in the random tree, IRQF_SAMPLE_RANDOM is now a
> no-op; interrupt randomness is now collected unconditionally in a very
> low-overhead fashion; see commit 775f4b297b. The IRQF_SAMPLE_RANDOM
> flag was scheduled to be removed in 2009 on the
> feature-removal-schedule, so this patch is preparation for the final
> removal of this flag.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Anton Vorontsov <cbou@mail.ru>
> Cc: David Woodhouse <dwmw2@infradead.org>
> ---
Applied, thanks!
> drivers/power/pda_power.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
> index 214468f..db5c526 100644
> --- a/drivers/power/pda_power.c
> +++ b/drivers/power/pda_power.c
> @@ -24,11 +24,7 @@
>
> static inline unsigned int get_irq_flags(struct resource *res)
> {
> - unsigned int flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED;
> -
> - flags |= res->flags & IRQF_TRIGGER_MASK;
> -
> - return flags;
> + return IRQF_SHARED | (res->flags & IRQF_TRIGGER_MASK);
> }
>
> static struct device *dev;
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-07-18 4:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 21:32 [PATCH 00/17] Extirpate IRQF_SAMPLE_REMOVE from the kernel Theodore Ts'o
2012-07-17 21:32 ` [PATCH 01/17] mfd: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
2012-07-17 21:32 ` [PATCH 02/17] input/serio/hp_sdc.c: " Theodore Ts'o
2012-07-18 6:09 ` Dmitry Torokhov
2012-07-18 17:05 ` Theodore Ts'o
2012-07-17 21:32 ` [PATCH 03/17] i2c-pmcmsp: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 04/17] pda_power: " Theodore Ts'o
2012-07-18 4:00 ` Anton Vorontsov [this message]
2012-07-18 4:18 ` Theodore Ts'o
2012-07-18 4:56 ` Anton Vorontsov
2012-07-17 21:32 ` [PATCH 05/17] n2_crypto: " Theodore Ts'o
2012-07-18 0:48 ` Herbert Xu
2012-07-17 21:32 ` [PATCH 06/17] xen-blkfront: " Theodore Ts'o
2012-07-19 19:44 ` Konrad Rzeszutek Wilk
2012-07-17 21:32 ` [PATCH 07/17] drivers: hv: " Theodore Ts'o
2012-07-18 13:14 ` KY Srinivasan
2012-07-17 21:32 ` [PATCH 08/17] uartlite: " Theodore Ts'o
2012-07-18 4:41 ` Peter Korsgaard
2012-07-17 21:32 ` [PATCH 09/17] goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out Theodore Ts'o
2012-07-17 21:32 ` [PATCH 10/17] omap_udc: remove IRQF_SAMPLE_RANDOM which is now a no-op Theodore Ts'o
2012-07-17 21:32 ` [PATCH 11/17] pxa25x_udc: " Theodore Ts'o
2012-07-19 3:07 ` Haojian Zhuang
2012-07-17 21:32 ` [PATCH 12/17] isp1301_omap: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 13/17] board-palmz71: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 14/17] [ARM] pxa: " Theodore Ts'o
2012-07-19 3:08 ` Haojian Zhuang
2012-07-17 21:32 ` [PATCH 15/17] sparc/ldc: " Theodore Ts'o
2012-07-17 22:06 ` David Miller
2012-07-17 21:32 ` [PATCH 16/17] um: " Theodore Ts'o
2012-07-17 21:32 ` [PATCH 17/17] random: final removal of IRQF_SAMPLE_RANDOM Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718040008.GA22599@lizard \
--to=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.