From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrT8L-0008UC-Tv for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:13:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrT8K-0000Cw-Lm for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:13:37 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:53455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrT8K-0000Co-BX for qemu-devel@nongnu.org; Wed, 18 Jul 2012 08:13:36 -0400 From: Mike Frysinger Date: Wed, 18 Jul 2012 08:13:53 -0400 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <500435B8.2010909@redhat.com> <50043A3F.5010501@weilnetz.de> In-Reply-To: <50043A3F.5010501@weilnetz.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1992009.EgpZJ3G3a7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201207180813.54820.vapier@gentoo.org> Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Eric Blake , qemu-devel@nongnu.org --nextPart1992009.EgpZJ3G3a7 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Monday 16 July 2012 11:58:55 Stefan Weil wrote: > Am 16.07.2012 17:39, schrieb Eric Blake: > > On 07/15/2012 01:54 PM, Stefan Weil wrote: > >> Am 15.07.2012 22:26, schrieb Mike Frysinger: > >>> We should not quote the PKG_CONFIG setting as this deviates from the > >>> canonical upstream behavior that gets integrated with all other build > >>> systems, and deviates from how we treat all other toolchain variables > >>> that we get from the environment. > >>>=20 > >>> Ultimately, the point is that it breaks passing custom flags directly > >>> to pkg-config via the env var where this normally works elsewhere, > >>> and it used to work in the past. > >>=20 > >> What about passing custom flags with QEMU_PKG_CONFIG_FLAGS? > >>=20 > >> Removing the quotes will not allow paths containing spaces, > >> so that's not a good idea. > >=20 > > Actually, it IS a good idea. The de facto standard build environment > > requires that pkg-config is not allowed to live in a path containing > > spaces, precisely so that you can override the variable to pass options > > to your preferred location of pkg-config; and if your build setup is > > truly so messed up as to have pkg-config installed in a canonical > > location with spaces, then you can also tweak your unusual environment > > to provide a symlink to pkg-config that does not contain spaces as the > > workaround. >=20 > That sounds reasonable. Then the following patch was at least partially > unnecessary: >=20 > commit 17884d7b6462b0fe497f08fec6091ffbe04caa8d > Author: Sergei Trofimovich > Date: Tue Jan 31 22:03:45 2012 +0300 >=20 > ./configure: request pkg-config to provide private libs when static > linking >=20 > Added wrapper around pkg-config to allow: > - safe options injection via ${QEMU_PKG_CONFIG_FLAGS} > - spaces in path to pkg-config >=20 > Signed-off-by: Sergei Trofimovich > CC: Peter Maydell > Signed-off-by: Anthony Liguori >=20 > With Mike's new patch, QEMU_PKG_CONFIG_FLAGS is no longer needed > because options can be passed using the pkg-config macro. > I suggest to remove it. i'm ambivalent on the additional functionality that qemu provides in its bu= ild=20 system -- i'm just concerned with the baseline being the same as all other= =20 build systems. some people probably find this handy. =2Dmike --nextPart1992009.EgpZJ3G3a7 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQBqiCAAoJEEFjO5/oN/WBvs0P/RDsq+qjKVdTpKRXwLcrsoHJ phW0o/CM2S+f22iI3hI6F09/OFi0Wp7VUdLnCqn5CUN8rVyQb33w3gn8/Hl5U3rn HBzrJYEEEKSladSU61nTb//ouolGuWPwOF5t4cuPWoWLVQqPkcFwiIZiMHyUNxbB ICDQXCH8dbg810n4LjSgmT6HPSjCcLXHvNN+DgwTeSSMUs4DyRTXZTqagRA0Qhab 5DGR/FZ6cD2AJADTdbZCF6iqqXrbGrlzeNUnFU1OHaHXUrqWmDJLVN7WUxvsWKUF mTnlk70BecgPS/3DCmdPSbFT+KhUAu2Yo0U+vMt7hKmSC8kBmvGN+VBbrxBf54ok 5jjcy4XRCZWb3FbYLmcPHLUyA8n89xJQw83Ie9OtLeaWzVR0vprzcSlzxTRHdbnZ JZaZ8nQGXpsfCGxaYojUUGqQtSgHcRcd44OjaZnA3iH8eBtvYKchWSX53JUYYuLh ahzuH1tgtPkI0K8styPNZKqRwLrqBTpr0QBbyEkA+LG4ekfbc1MBXOWAiFAi+Uz+ osQCJc1o554UhfoRUAFIeTPw83C6H6233w9ZxQjvWINrIw3xBldFUL4Oxpi03Tad eV9cCoFbZsdRy5tRBM0yuInABfu8wFgfZjXacqo8YNHMXGpDI9idpfR3NebCfFpO 2twMHylqc+O/gWXwoERk =D3KQ -----END PGP SIGNATURE----- --nextPart1992009.EgpZJ3G3a7--