From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118Ab2GRJGw (ORCPT ); Wed, 18 Jul 2012 05:06:52 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:43538 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939Ab2GRJGo (ORCPT ); Wed, 18 Jul 2012 05:06:44 -0400 Date: Wed, 18 Jul 2012 10:06:26 +0100 From: Catalin Marinas To: Benjamin Herrenschmidt Cc: "linux-kernel@vger.kernel.org" , Arnd Bergmann , Will Deacon Subject: Re: [PATCH 01/36] atomic64_test: Simplify the #ifdef for atomic64_dec_if_positive() test Message-ID: <20120718090626.GA23190@arm.com> References: <1341608777-12982-1-git-send-email-catalin.marinas@arm.com> <1341608777-12982-2-git-send-email-catalin.marinas@arm.com> <1342586037.3669.16.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342586037.3669.16.camel@pasglop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 18, 2012 at 05:33:57AM +0100, Benjamin Herrenschmidt wrote: > On Fri, 2012-07-06 at 22:05 +0100, Catalin Marinas wrote: > > This patch introduces ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE and uses this > > instead of the multitude of #if defined() checks in atomic64_test.c > > > > Signed-off-by: Will Deacon > > Signed-off-by: Catalin Marinas > > I'll let other paint the bike shed as to whether ARCH_HAS_* is the right > thing here, but as far as the powerpc change is concerned: > > Acked-by: Benjamin Herrenschmidt Thanks Ben. I followed Andrew's feedback to some other patches that Will posted and moved the #define to Kconfig: https://lkml.org/lkml/2012/7/17/382 I don't have any strong preference. -- Catalin