From: Tejun Heo <tj@kernel.org>
To: Aristeu Rozanski <aris@redhat.com>
Cc: linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
Hugh Dickins <hughd@google.com>, Hillf Danton <dhillf@gmail.com>
Subject: Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory
Date: Wed, 18 Jul 2012 09:32:29 -0700 [thread overview]
Message-ID: <20120718163229.GH24336@google.com> (raw)
In-Reply-To: <20120718141604.GC26916@redhat.com>
Hello,
On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote:
> > Yeah, generally looks good to me although @added/removed_bits argument
> > names irk me a bit. The name may be okay for local variables but I
> > keep thinking "what bits?". @subsys_mask or something indicating that
> > it's mask of subsystems would better. Also, can you please add /**
> > function comment explaining the clear/populate functions and their
> > arguments?
>
> agreed. although the "_bits" thing is spread all around the code. you
> want that cleaned up too? (I can post a followup patch after this
> patchset is done)
Yeah, that would be great.
Thanks a lot!
--
tejun
next prev parent reply other threads:[~2012-07-18 16:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 14:29 [PATCH v3 0/3] cgroup: add xattr support Aristeu Rozanski
2012-07-02 14:29 ` [PATCH v3 1/3] xattr: extract simple_xattr code from tmpfs Aristeu Rozanski
2012-07-03 16:53 ` [PATCH v4 " Aristeu Rozanski
2012-07-02 14:29 ` [PATCH v3 2/3] cgroup: revise how we re-populate root directory Aristeu Rozanski
2012-07-09 17:17 ` Tejun Heo
2012-07-09 17:22 ` Tejun Heo
2012-07-09 17:28 ` Tejun Heo
2012-07-10 19:27 ` Aristeu Rozanski
2012-07-17 13:56 ` Aristeu Rozanski
2012-07-17 18:38 ` Tejun Heo
2012-07-17 21:29 ` Aristeu Rozanski
2012-07-17 21:40 ` Tejun Heo
2012-07-18 14:16 ` Aristeu Rozanski
2012-07-18 16:32 ` Tejun Heo [this message]
2012-07-02 14:29 ` [PATCH v3 3/3] cgroup: add xattr support Aristeu Rozanski
2012-07-17 20:41 ` [PATCH v3 0/3] " Tejun Heo
2012-07-18 20:02 ` Hugh Dickins
2012-07-18 22:10 ` Tejun Heo
2012-07-19 1:11 ` Hugh Dickins
2012-07-20 17:59 ` Aristeu Rozanski
2012-07-20 18:04 ` Tejun Heo
2012-08-07 15:22 ` Aristeu Rozanski
2012-07-22 19:12 ` Hugh Dickins
2012-07-23 18:12 ` Aristeu Rozanski
2012-07-24 18:28 ` Tejun Heo
2012-07-24 21:44 ` Aristeu Rozanski
2012-07-20 18:10 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120718163229.GH24336@google.com \
--to=tj@kernel.org \
--cc=aris@redhat.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.