All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nds32: split common cache access from cpu into lib
Date: Thu, 19 Jul 2012 11:02:21 +0200	[thread overview]
Message-ID: <201207191102.21389.marex@denx.de> (raw)
In-Reply-To: <201207190037.59281.vapier@gentoo.org>

Dear Mike Frysinger,

> On Sunday 15 July 2012 04:12:45 Marek Vasut wrote:
> > Dear Macpaul Lin,
> > 
> > > +void flush_cache(unsigned long addr, unsigned long size)
> > > +{
> > > +	flush_dcache_range(addr, addr + size);
> > > +	invalidate_icache_range(addr, addr + size);
> > 
> > You probably want to flush dcache in here and that's it.
> 
> i don't think so ... i think that's what flush_dcache_range() is for.  and
> our common/cmd_*.c files assume that flush_cache() will invalidate icache
> (see the bootm/load funcs that write executable content into memory and
> then flush the regions).

Than it's borked on arm926ejs too ... ?

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-07-19  9:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-15  4:02 [U-Boot] [PATCH] nds32: split common cache access from cpu into lib Macpaul Lin
2012-07-15  8:12 ` Marek Vasut
2012-07-16  2:23   ` Macpaul Lin
2012-07-17 13:44     ` [U-Boot] [PATCH v2] " Macpaul Lin
2012-07-20 16:03       ` Macpaul Lin
2012-07-19  4:37   ` [U-Boot] [PATCH] " Mike Frysinger
2012-07-19  4:51     ` Macpaul Lin
2012-07-19  9:02     ` Marek Vasut [this message]
2012-07-19 13:48       ` Mike Frysinger
2012-07-19 14:02         ` Marek Vasut
2012-07-20  8:24           ` Macpaul Lin
2012-07-20 14:41             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201207191102.21389.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.