From: Ismael Luceno <ismael.luceno@gmail.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH 10/10] staging: solo6x10: Avoid extern declaration by reworking module parameter
Date: Thu, 19 Jul 2012 15:41:11 -0300 [thread overview]
Message-ID: <20120719154111.2e4296b9@pirotess> (raw)
In-Reply-To: <CALF0-+W88U_cAGMrui9rwbNg8BBgekBi9B2unStKySY_RhS3zw@mail.gmail.com>
On Thu, 19 Jul 2012 10:25:09 -0300
Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno
> <ismael.luceno@gmail.com> wrote:
> > On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia
> > <elezegarcia@gmail.com> wrote:
> >> This patch moves video_nr module parameter to core.c
> >> and then passes that parameter as an argument to functions
> >> that need it.
> >> This way we avoid the extern declaration and parameter
> >> dependencies are better exposed.
> > <...>
> >
> > NACK.
> >
> > The changes to video_nr are supposed to be preserved.
>
> Mmm, I'm sorry but I don't see any functionality change in this patch,
> just a cleanup.
>
> What do you mean by "changes to video_nr are supposed to be
> preserved"?
It is modified by solo_enc_alloc, which is called multiple times by
solo_enc_v4l2_init.
next prev parent reply other threads:[~2012-07-19 18:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 19:52 [PATCH 01/10] staging: solo6x10: Fix TODO file with proper maintainer Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 02/10] staging: solo6x10: Use linux/{io,uaccess}.h instead of asm/{io,uaccess}.h Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 03/10] staging: solo6x10: Replace C++ style comment with C style Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 04/10] staging: solo6x10: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 05/10] staging: solo6x10: Remove format type mismatch warning Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 06/10] staging: solo6x10: Replace printk(KERN_WARNING with dev_warn Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 07/10] staging: solo6x10: Merge quoted string split across lines Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 08/10] staging: solo6x10: Declare static const array properly Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 09/10] staging: solo6x10: Fix several over 80 character lines Ezequiel Garcia
2012-06-21 19:52 ` [PATCH 10/10] staging: solo6x10: Avoid extern declaration by reworking module parameter Ezequiel Garcia
2012-07-18 22:26 ` Ismael Luceno
2012-07-19 13:25 ` Ezequiel Garcia
2012-07-19 18:41 ` Ismael Luceno [this message]
2012-07-19 19:18 ` Ezequiel Garcia
2012-07-19 19:48 ` Hans Verkuil
2012-07-19 19:55 ` Ezequiel Garcia
2012-07-19 20:41 ` Hans Verkuil
2012-07-19 20:55 ` Ezequiel Garcia
2012-07-19 20:42 ` Ismael Luceno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719154111.2e4296b9@pirotess \
--to=ismael.luceno@gmail.com \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.