From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/radeon/kms: improve bpc handling (v2) Date: Thu, 19 Jul 2012 22:29:29 +0300 Message-ID: <20120719192929.GA5292@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by gabe.freedesktop.org (Postfix) with ESMTP id C0B2B9F065 for ; Thu, 19 Jul 2012 12:29:39 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: alexander.deucher@amd.com Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello Alex Deucher, This is a semi-automatic email about new static checker warnings. The patch eccea7920cfb: "drm/radeon/kms: improve bpc handling (v2)" from Mar 26, 2012, leads to the following Smatch complaint: drivers/gpu/drm/radeon/atombios_crtc.c:599 atombios_adjust_pll() warn: variable dereferenced before check 'connector' (see line 594) drivers/gpu/drm/radeon/atombios_crtc.c 593 connector = radeon_get_connector_for_encoder(encoder); 594 bpc = radeon_get_monitor_bpc(connector); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ New dereference inside the call to radeon_get_monitor_bpc(). 595 encoder_mode = atombios_get_encoder_mode(encoder); 596 is_duallink = radeon_dig_monitor_is_duallink(encoder, mode->clock); 597 if ((radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT | ATOM_DEVICE_DFP_SUPPORT)) || 598 (radeon_encoder_get_dp_bridge_encoder_id(encoder) != ENCODER_OBJECT_ID_NONE)) { 599 if (connector) { ^^^^^^^^^ Old check. 600 struct radeon_connector *radeon_connector = to_radeon_connector(connector); 601 struct radeon_connector_atom_dig *dig_connector = regards, dan carpenter