From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58185)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SsAyH-0000ei-IP
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 07:02:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SsAy8-0003YY-3W
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 07:02:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SsAy7-0003YU-SO
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 07:02:00 -0400
Date: Fri, 20 Jul 2012 14:02:32 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120720110232.GC1357@redhat.com>
References: <20120719142949.GA14567@redhat.com>
	<CAFEAcA_C=+BkuefzGb=cxxB7hA-pht=hvzD4MT4KWvs1-hBf-Q@mail.gmail.com>
	<20120719152426.GA16101@redhat.com>
	<CAJSP0QUfXrxXUFTKcS_3Giw7cq3pXveXAOA_m78BzGi2+SLX4g@mail.gmail.com>
	<CAFEAcA8to_9XmFPU-3NdN5Esg2Z8jEd8Pe0+KbaQ0Z==NOao_Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8to_9XmFPU-3NdN5Esg2Z8jEd8Pe0+KbaQ0Z==NOao_Q@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: add .exrc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

On Fri, Jul 20, 2012 at 11:34:21AM +0100, Peter Maydell wrote:
> On 20 July 2012 11:26, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > From my .vimrc:
> >
> > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool
> > setlocal ts=4 sw=4 et
> 
> Basically I think editor preferences are a local matter which
> can reasonably differ between different developers, so they
> shouldn't be in the git repo.

This is why I simply set the shiftwidth and set indenting by space.
Clearly no "can reasonably differ" applies here.

> (a) haven't you just demonstrated that even vim users have
> different preferred settings?

No, it's the same with the addition of tabstop=4, which *is*
a matter of taste (how many spaces you want shown if you edit
a file with tabs, like a makefile).

> (b) where do we stop? emacs? bbedit? there are a lot of editors
> out there...

If people ask for it we can consider. I doubt it will be a real problem.

> In any case, 3 settings clearly don't encompass the whole of
> QEMU's coding style.
> The relevant bit of my .emacs tweaks about
> 20 different settings...
> 
> -- PMM

If you don't use vim why do you even care about this patch?

-- 
MST