From: Dave Jones <davej@redhat.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Darren Hart <darren@dvhart.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: 3.5-rc6 futex_wait_requeue_pi oops.
Date: Fri, 20 Jul 2012 09:35:01 -0400 [thread overview]
Message-ID: <20120720133501.GA30826@redhat.com> (raw)
In-Reply-To: <50090079.1000703@linux.intel.com>
On Thu, Jul 19, 2012 at 11:53:45PM -0700, Darren Hart wrote:
> >> I'll add a fix to that WARN_ON in my futex-fixes branch along with the
> >> fix for the bug Dan found.
> >
> > I think I have root cause. futex_wait_requeue_pi() doesn't like having
> > uaddr == uaddr2. The handle_early_wakeup() doesn't detect a problem
> > because key2 IS the same as key1, I think. I've just discovered this and
> > quickly hacked in a "if (uaddr==uaddr2) return -EINVAL" fix and the test
> > continues to run (with just ops 0, 11, 12) for several minutes now
> > (typically fails in a few seconds). I'll let it run for a few hours and
> > contemplate the proper fix.
>
> Dave, mind giving this a spin? It seems to be doing the trick here,
> at least for the *REQUEUE_PI futex op codes in trinity.
Yeah, looks like that does the trick!
thanks,
Dave
next prev parent reply other threads:[~2012-07-20 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 18:08 3.5-rc6 futex_wait_requeue_pi oops Dave Jones
2012-07-13 18:47 ` Thomas Gleixner
2012-07-13 18:54 ` Dave Jones
2012-07-13 19:11 ` Thomas Gleixner
2012-07-13 19:56 ` Dave Jones
[not found] ` <CAGChsmNnE_iEKWagULzewSPWsAbaA2A-mXg4CS+vyG3a8Pbj1A@mail.gmail.com>
2012-07-13 20:54 ` Dave Jones
2012-07-19 23:22 ` Darren Hart
2012-07-20 0:37 ` Darren Hart
2012-07-20 6:53 ` Darren Hart
2012-07-20 13:35 ` Dave Jones [this message]
2012-07-20 15:10 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720133501.GA30826@redhat.com \
--to=davej@redhat.com \
--cc=darren@dvhart.com \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.